gnosis/lighthouse
1
0
Fork 0
mirror of https://github.com/sigp/lighthouse.git synced 2026-03-03 00:31:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Enable lints for tests only running optimized (#6664)

Browse Source 
* enable linting optimized-only tests

* fix automatically fixable or obvious lints

* fix suspicious_open_options by removing manual options

* fix `await_holding_lock`s

* avoid failing lint due to now disabled `#[cfg(debug_assertions)]`

* reduce future sizes in tests

* fix accidently flipped assert logic

* restore holding lock for web3signer download

* Merge branch 'unstable' into lint-opt-tests
This commit is contained in:
Daniel Knopik
2024-12-17 01:40:35 +01:00
committed by GitHub
parent 847c8019c7
commit 02cb2d68ff
34 changed files with 572 additions and 574 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
crypto/eth2_keystore/tests/eip2335_vectors.rs
View File

@@ -58,7 +58,7 @@ fn eip2335_test_vector_scrypt() {
}
"#;
let keystore = decode_and_check_sk(&vector);
let keystore = decode_and_check_sk(vector);
assert_eq!(
*keystore.uuid(),
Uuid::parse_str("1d85ae20-35c5-4611-98e8-aa14a633906f").unwrap(),
@@ -102,7 +102,7 @@ fn eip2335_test_vector_pbkdf() {
}
"#;
let keystore = decode_and_check_sk(&vector);
let keystore = decode_and_check_sk(vector);
assert_eq!(
*keystore.uuid(),
Uuid::parse_str("64625def-3331-4eea-ab6f-782f3ed16a83").unwrap(),

14
crypto/eth2_keystore/tests/tests.rs
View File

@@ -54,25 +54,17 @@ fn file() {
let dir = tempdir().unwrap();
let path = dir.path().join("keystore.json");
let get_file = || {
File::options()
.write(true)
.read(true)
.create(true)
.open(path.clone())
.expect("should create file")
};
let keystore = KeystoreBuilder::new(&keypair, GOOD_PASSWORD, "".into())
.unwrap()
.build()
.unwrap();
keystore
.to_json_writer(&mut get_file())
.to_json_writer(File::create_new(&path).unwrap())
.expect("should write to file");
let decoded = Keystore::from_json_reader(&mut get_file()).expect("should read from file");
let decoded =
Keystore::from_json_reader(File::open(&path).unwrap()).expect("should read from file");
assert_eq!(
decoded.decrypt_keypair(BAD_PASSWORD).err().unwrap(),

13
crypto/eth2_wallet/tests/tests.rs
View File

@@ -132,20 +132,11 @@ fn file_round_trip() {
let dir = tempdir().unwrap();
let path = dir.path().join("keystore.json");
let get_file = || {
File::options()
.write(true)
.read(true)
.create(true)
.open(path.clone())
.expect("should create file")
};
wallet
.to_json_writer(&mut get_file())
.to_json_writer(File::create_new(&path).unwrap())
.expect("should write to file");
let decoded = Wallet::from_json_reader(&mut get_file()).unwrap();
let decoded = Wallet::from_json_reader(File::open(&path).unwrap()).unwrap();
assert_eq!(
decoded.decrypt_seed(&[1, 2, 3]).err().unwrap(),