From 02d519e95706afb520329fd9bf8a5b85a61de150 Mon Sep 17 00:00:00 2001 From: Jimmy Chen Date: Thu, 11 Sep 2025 07:02:27 +1000 Subject: [PATCH] Fixed orphaned `verify_cell_proof_chunk` span. (#8026) Fixed orphaned kzg verify cell proof chunk spans. See screenshot: image The parent span needs to be passed explicitly to the chunk verification span as parent, as rayon runs the function in a separate thread. Co-Authored-By: Jimmy Chen Co-Authored-By: Eitan Seri-Levi --- crypto/kzg/src/lib.rs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/crypto/kzg/src/lib.rs b/crypto/kzg/src/lib.rs index 1b8d46100f..0fe95b7723 100644 --- a/crypto/kzg/src/lib.rs +++ b/crypto/kzg/src/lib.rs @@ -23,7 +23,7 @@ pub use rust_eth_kzg::{ constants::{BYTES_PER_CELL, CELLS_PER_EXT_BLOB}, Cell, CellIndex as CellID, CellRef, TrustedSetup as PeerDASTrustedSetup, }; -use tracing::instrument; +use tracing::{instrument, Span}; /// Disables the fixed-base multi-scalar multiplication optimization for computing /// cell KZG proofs, because `rust-eth-kzg` already handles the precomputation. @@ -269,6 +269,7 @@ impl Kzg { .push((cell, *proof, *commitment)); } + let span = Span::current(); column_groups .into_par_iter() .map(|(column_index, column_data)| { @@ -286,6 +287,7 @@ impl Kzg { // This is safe from span explosion as we have at most 128 chunks, // i.e. the number of column indices. let _span = tracing::debug_span!( + parent: span.clone(), "verify_cell_proof_chunk", cells = cells.len(), column_index,