Clean capella (#4019)

## Issue Addressed

Cleans up all the remnants of 4844 in capella. This makes sure when 4844 is reviewed there is nothing we are missing because it got included here 

## Proposed Changes

drop a bomb on every 4844 thing 

## Additional Info

Merge process I did (locally) is as follows:
- squash merge to produce one commit
- in new branch off unstable with the squashed commit create a `git revert HEAD` commit
- merge that new branch onto 4844 with `--strategy ours`
- compare local 4844 to remote 4844 and make sure the diff is empty
- enjoy

Co-authored-by: Paul Hauner <paul@paulhauner.com>

beacon_node/network/src/router/mod.rs

@@ -168,9 +168,6 @@ impl<T: BeaconChainTypes> Router<T> {
             Request::BlocksByRoot(request) => self
                 .processor
                 .on_blocks_by_root_request(peer_id, id, request),
-            Request::BlobsByRange(request) => self
-                .processor
-                .on_blobs_by_range_request(peer_id, id, request),
             Request::LightClientBootstrap(request) => self
                 .processor
                 .on_lightclient_bootstrap(peer_id, id, request),
@@ -198,10 +195,6 @@ impl<T: BeaconChainTypes> Router<T> {
                 self.processor
                     .on_blocks_by_root_response(peer_id, request_id, beacon_block);
             }
-            Response::BlobsByRange(beacon_blob) => {
-                self.processor
-                    .on_blobs_by_range_response(peer_id, request_id, beacon_blob);
-            }
             Response::LightClientBootstrap(_) => unreachable!(),
         }
     }
@@ -240,14 +233,6 @@ impl<T: BeaconChainTypes> Router<T> {
                     block,
                 );
             }
-            PubsubMessage::BeaconBlockAndBlobsSidecars(block_and_blobs) => {
-                self.processor.on_block_and_blobs_sidecar_gossip(
-                    id,
-                    peer_id,
-                    self.network_globals.client(&peer_id),
-                    block_and_blobs,
-                );
-            }
             PubsubMessage::VoluntaryExit(exit) => {
                 debug!(self.log, "Received a voluntary exit"; "peer_id" => %peer_id);
                 self.processor.on_voluntary_exit_gossip(id, peer_id, exit);

beacon_node/network/src/router/processor.rs

@@ -6,8 +6,7 @@ use crate::status::status_message;
 use crate::sync::manager::RequestId as SyncId;
 use crate::sync::SyncMessage;
 use beacon_chain::{BeaconChain, BeaconChainTypes};
-use lighthouse_network::rpc::methods::BlobsByRangeRequest;
-use lighthouse_network::{rpc::*, SignedBeaconBlockAndBlobsSidecar};
+use lighthouse_network::rpc::*;
 use lighthouse_network::{
     Client, MessageId, NetworkGlobals, PeerId, PeerRequestId, Request, Response,
 };
@@ -18,10 +17,9 @@ use std::time::{Duration, SystemTime, UNIX_EPOCH};
 use store::SyncCommitteeMessage;
 use tokio::sync::mpsc;
 use types::{
-    Attestation, AttesterSlashing, BlobsSidecar, EthSpec, LightClientFinalityUpdate,
-    LightClientOptimisticUpdate, ProposerSlashing, SignedAggregateAndProof, SignedBeaconBlock,
-    SignedBlsToExecutionChange, SignedContributionAndProof, SignedVoluntaryExit, SubnetId,
-    SyncSubnetId,
+    Attestation, AttesterSlashing, EthSpec, LightClientFinalityUpdate, LightClientOptimisticUpdate,
+    ProposerSlashing, SignedAggregateAndProof, SignedBeaconBlock, SignedBlsToExecutionChange,
+    SignedContributionAndProof, SignedVoluntaryExit, SubnetId, SyncSubnetId,
 };
 
 /// Processes validated messages from the network. It relays necessary data to the syncing thread
@@ -163,17 +161,6 @@ impl<T: BeaconChainTypes> Processor<T> {
         ))
     }
 
-    pub fn on_blobs_by_range_request(
-        &mut self,
-        peer_id: PeerId,
-        request_id: PeerRequestId,
-        request: BlobsByRangeRequest,
-    ) {
-        self.send_beacon_processor_work(BeaconWorkEvent::blobs_by_range_request(
-            peer_id, request_id, request,
-        ))
-    }
-
     /// Handle a `LightClientBootstrap` request from the peer.
     pub fn on_lightclient_bootstrap(
         &mut self,
@@ -230,33 +217,6 @@ impl<T: BeaconChainTypes> Processor<T> {
         });
     }
 
-    pub fn on_blobs_by_range_response(
-        &mut self,
-        peer_id: PeerId,
-        request_id: RequestId,
-        blob_wrapper: Option<Arc<BlobsSidecar<T::EthSpec>>>,
-    ) {
-        trace!(
-            self.log,
-            "Received BlobsByRange Response";
-            "peer" => %peer_id,
-        );
-
-        if let RequestId::Sync(id) = request_id {
-            self.send_to_sync(SyncMessage::RpcBlob {
-                peer_id,
-                request_id: id,
-                blob_sidecar: blob_wrapper,
-                seen_timestamp: timestamp_now(),
-            });
-        } else {
-            debug!(
-                self.log,
-                "All blobs by range responses should belong to sync"
-            );
-        }
-    }
-
     /// Handle a `BlocksByRoot` response from the peer.
     pub fn on_blocks_by_root_response(
         &mut self,
@@ -308,22 +268,6 @@ impl<T: BeaconChainTypes> Processor<T> {
         ))
     }
 
-    pub fn on_block_and_blobs_sidecar_gossip(
-        &mut self,
-        message_id: MessageId,
-        peer_id: PeerId,
-        peer_client: Client,
-        block_and_blobs: Arc<SignedBeaconBlockAndBlobsSidecar<T::EthSpec>>,
-    ) {
-        self.send_beacon_processor_work(BeaconWorkEvent::gossip_block_and_blobs_sidecar(
-            message_id,
-            peer_id,
-            peer_client,
-            block_and_blobs,
-            timestamp_now(),
-        ))
-    }
-
     pub fn on_unaggregated_attestation_gossip(
         &mut self,
         message_id: MessageId,