gnosis/lighthouse
1
0
Fork 0
mirror of https://github.com/sigp/lighthouse.git synced 2026-05-07 16:55:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add comment to max cover optimisation

Browse Source
This commit is contained in:
Michael Sproul
2024-05-10 12:44:18 +10:00
parent 437e8516cd
commit 16265ef455
1 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
beacon_node/operation_pool/src/attestation.rs
View File

@@ -144,6 +144,13 @@ impl<'a, E: EthSpec> MaxCover for AttMaxCover<'a, E> {
/// because including two attestations on chain to satisfy different participation bits is /// because including two attestations on chain to satisfy different participation bits is
/// impossible without the validator double voting. I.e. it is only suboptimal in the presence /// impossible without the validator double voting. I.e. it is only suboptimal in the presence
/// of slashable voting, which is rare. /// of slashable voting, which is rare.
///
/// Post-Electra this optimisation is still OK. The `self.att.data.index` will always be 0 for
/// all Electra attestations, so when a new attestation is added to the solution, we will
/// remove its validators from all attestations at the same slot. It may happen that the
/// included attestation and the attestation being updated have no validators in common, in
/// which case the `retain` will be a no-op. We could consider optimising this in future by only
/// executing the `retain` when the `committee_bits` of the two attestations intersect.
fn update_covering_set( fn update_covering_set(
&mut self, &mut self,
best_att: &AttestationRef<'a, E>, best_att: &AttestationRef<'a, E>,