Tidy eth1/deposit contract logging (#3397)

## Issue Addressed

Fixes an issue identified by @remyroy whereby we were logging a recommendation to use `--eth1-endpoints` on merge-ready setups (when the execution layer was out of sync).

## Proposed Changes

I took the opportunity to clean up the other eth1-related logs, replacing "eth1" by "deposit contract" or "execution" as appropriate.

I've downgraded the severity of the `CRIT` log to `ERRO` and removed most of the recommendation text. The reason being that users lacking an execution endpoint will be informed by the new `WARN Not merge ready` log pre-Bellatrix, or the regular errors from block verification post-Bellatrix.
This commit is contained in:
Michael Sproul
2022-08-01 07:20:43 +00:00
parent 2983235650
commit 18383a63b2
5 changed files with 35 additions and 42 deletions

View File

@@ -45,7 +45,7 @@ impl<T> Fallback<T> {
{
match error {
FallbackError::AllErrored(v) => format!(
"All fallback errored: {}",
"All fallbacks errored: {}",
join(
zip(self.servers.iter().map(f), v.iter())
.map(|(server, error)| format!("{} => {:?}", server, error)),