gnosis/lighthouse
1
0
Fork 0
mirror of https://github.com/sigp/lighthouse.git synced 2026-05-08 09:16:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

Optimise mutations in single-pass epoch processing (#4573)

Browse Source 
* Optimise mutations in single-pass epoch processing

* Use safer Cow::make_mut

* Update to upstream milhouse
This commit is contained in:
Michael Sproul
2023-08-08 11:25:26 +10:00
committed by GitHub
parent 8423e9f554
commit 18e64e60ad
5 changed files with 38 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
Cargo.lock generated
View File

@@ -5202,7 +5202,7 @@ dependencies = [
[[package]] [[package]]
name = "milhouse" name = "milhouse"
version = "0.1.0" version = "0.1.0"
source = "git+https://github.com/sigp/milhouse?branch=main#e30719aaf1e4b46e3ff1962f7370965e68fa548b" source = "git+https://github.com/sigp/milhouse?branch=main#d106d79a434967f4c112bbcf8591fcc7e21baad9"
dependencies = [ dependencies = [
"arbitrary", "arbitrary",
"derivative", "derivative",

2
consensus/state_processing/src/common/initiate_validator_exit.rs
View File

@@ -35,7 +35,7 @@ pub fn initiate_validator_exit<T: EthSpec>(
return Ok(()); return Ok(());
} }
let validator = validator.to_mut(); let validator = validator.into_mut()?;
validator.mutable.exit_epoch = exit_queue_epoch; validator.mutable.exit_epoch = exit_queue_epoch;
validator.mutable.withdrawable_epoch = validator.mutable.withdrawable_epoch =
exit_queue_epoch.safe_add(spec.min_validator_withdrawability_delay)?; exit_queue_epoch.safe_add(spec.min_validator_withdrawability_delay)?;

2
consensus/state_processing/src/genesis.rs
View File

@@ -118,7 +118,7 @@ pub fn process_activations<T: EthSpec>(
let (validators, balances, _) = state.validators_and_balances_and_progressive_balances_mut(); let (validators, balances, _) = state.validators_and_balances_and_progressive_balances_mut();
let mut validators_iter = validators.iter_cow(); let mut validators_iter = validators.iter_cow();
while let Some((index, validator)) = validators_iter.next_cow() { while let Some((index, validator)) = validators_iter.next_cow() {
let validator = validator.to_mut(); let validator = validator.into_mut()?;
let balance = balances let balance = balances
.get(index) .get(index)
.copied() .copied()

2
consensus/state_processing/src/per_epoch_processing/effective_balance_updates.rs
View File

@@ -45,7 +45,7 @@ pub fn process_effective_balance_updates<T: EthSpec>(
} }
if new_effective_balance != validator.effective_balance() { if new_effective_balance != validator.effective_balance() {
validator.to_mut().mutable.effective_balance = new_effective_balance; validator.into_mut()?.mutable.effective_balance = new_effective_balance;
} }
} }

64
consensus/state_processing/src/per_epoch_processing/single_pass.rs
View File

@@ -12,6 +12,7 @@ use types::{
NUM_FLAG_INDICES, PARTICIPATION_FLAG_WEIGHTS, TIMELY_HEAD_FLAG_INDEX, NUM_FLAG_INDICES, PARTICIPATION_FLAG_WEIGHTS, TIMELY_HEAD_FLAG_INDEX,
TIMELY_TARGET_FLAG_INDEX, WEIGHT_DENOMINATOR, TIMELY_TARGET_FLAG_INDEX, WEIGHT_DENOMINATOR,
}, },
milhouse::Cow,
ActivationQueue, BeaconState, BeaconStateError, ChainSpec, Epoch, EthSpec, ExitCache, ForkName, ActivationQueue, BeaconState, BeaconStateError, ChainSpec, Epoch, EthSpec, ExitCache, ForkName,
ParticipationFlags, ProgressiveBalancesCache, Unsigned, Validator, ParticipationFlags, ProgressiveBalancesCache, Unsigned, Validator,
}; };
@@ -180,20 +181,16 @@ pub fn process_epoch_single_pass<E: EthSpec>(
previous_epoch_participation.iter(), previous_epoch_participation.iter(),
current_epoch_participation.iter(), current_epoch_participation.iter(),
) { ) {
let (_, validator_cow) = validators_iter let (_, mut validator) = validators_iter
.next_cow() .next_cow()
.ok_or(BeaconStateError::UnknownValidator(index))?; .ok_or(BeaconStateError::UnknownValidator(index))?;
let (_, balance_cow) = balances_iter let (_, mut balance) = balances_iter
.next_cow() .next_cow()
.ok_or(BeaconStateError::UnknownValidator(index))?; .ok_or(BeaconStateError::UnknownValidator(index))?;
let (_, inactivity_score_cow) = inactivity_scores_iter let (_, mut inactivity_score) = inactivity_scores_iter
.next_cow() .next_cow()
.ok_or(BeaconStateError::UnknownValidator(index))?; .ok_or(BeaconStateError::UnknownValidator(index))?;
let validator = validator_cow.to_mut();
let balance = balance_cow.to_mut();
let inactivity_score = inactivity_score_cow.to_mut();
let is_active_current_epoch = validator.is_active_at(current_epoch); let is_active_current_epoch = validator.is_active_at(current_epoch);
let is_active_previous_epoch = validator.is_active_at(previous_epoch); let is_active_previous_epoch = validator.is_active_at(previous_epoch);
let is_eligible = is_active_previous_epoch let is_eligible = is_active_previous_epoch
@@ -222,7 +219,7 @@ pub fn process_epoch_single_pass<E: EthSpec>(
// `process_inactivity_updates` // `process_inactivity_updates`
if conf.inactivity_updates { if conf.inactivity_updates {
process_single_inactivity_update( process_single_inactivity_update(
inactivity_score, &mut inactivity_score,
validator_info, validator_info,
state_ctxt, state_ctxt,
spec, spec,
@@ -232,8 +229,8 @@ pub fn process_epoch_single_pass<E: EthSpec>(
// `process_rewards_and_penalties` // `process_rewards_and_penalties`
if conf.rewards_and_penalties { if conf.rewards_and_penalties {
process_single_reward_and_penalty( process_single_reward_and_penalty(
balance, &mut balance,
inactivity_score, &inactivity_score,
validator_info, validator_info,
rewards_ctxt, rewards_ctxt,
state_ctxt, state_ctxt,
@@ -245,7 +242,7 @@ pub fn process_epoch_single_pass<E: EthSpec>(
// `process_registry_updates` // `process_registry_updates`
if conf.registry_updates { if conf.registry_updates {
process_single_registry_update( process_single_registry_update(
validator, &mut validator,
validator_info, validator_info,
exit_cache, exit_cache,
activation_queue, activation_queue,
@@ -257,14 +254,14 @@ pub fn process_epoch_single_pass<E: EthSpec>(
// `process_slashings` // `process_slashings`
if conf.slashings { if conf.slashings {
process_single_slashing(balance, validator, slashings_ctxt, state_ctxt, spec)?; process_single_slashing(&mut balance, &validator, slashings_ctxt, state_ctxt, spec)?;
} }
// `process_effective_balance_updates` // `process_effective_balance_updates`
if conf.effective_balance_updates { if conf.effective_balance_updates {
process_single_effective_balance_update( process_single_effective_balance_update(
*balance, *balance,
validator, &mut validator,
validator_info, validator_info,
&mut next_epoch_total_active_balance, &mut next_epoch_total_active_balance,
&mut next_epoch_cache, &mut next_epoch_cache,
@@ -289,7 +286,7 @@ pub fn process_epoch_single_pass<E: EthSpec>(
} }
fn process_single_inactivity_update( fn process_single_inactivity_update(
inactivity_score: &mut u64, inactivity_score: &mut Cow<u64>,
validator_info: &ValidatorInfo, validator_info: &ValidatorInfo,
state_ctxt: &StateContext, state_ctxt: &StateContext,
spec: &ChainSpec, spec: &ChainSpec,
@@ -302,25 +299,27 @@ fn process_single_inactivity_update(
if validator_info.is_unslashed_participating_index(TIMELY_TARGET_FLAG_INDEX)? { if validator_info.is_unslashed_participating_index(TIMELY_TARGET_FLAG_INDEX)? {
// Avoid mutating when the inactivity score is 0 and can't go any lower -- the common // Avoid mutating when the inactivity score is 0 and can't go any lower -- the common
// case. // case.
if *inactivity_score == 0 { if **inactivity_score == 0 {
return Ok(()); return Ok(());
} }
inactivity_score.safe_sub_assign(1)?; inactivity_score.make_mut()?.safe_sub_assign(1)?;
} else { } else {
inactivity_score.safe_add_assign(spec.inactivity_score_bias)?; inactivity_score
.make_mut()?
.safe_add_assign(spec.inactivity_score_bias)?;
} }
// Decrease the score of all validators for forgiveness when not during a leak // Decrease the score of all validators for forgiveness when not during a leak
if !state_ctxt.is_in_inactivity_leak { if !state_ctxt.is_in_inactivity_leak {
inactivity_score let deduction = min(spec.inactivity_score_recovery_rate, **inactivity_score);
.safe_sub_assign(min(spec.inactivity_score_recovery_rate, *inactivity_score))?; inactivity_score.make_mut()?.safe_sub_assign(deduction)?;
} }
Ok(()) Ok(())
} }
fn process_single_reward_and_penalty( fn process_single_reward_and_penalty(
balance: &mut u64, balance: &mut Cow<u64>,
inactivity_score: &u64, inactivity_score: &u64,
validator_info: &ValidatorInfo, validator_info: &ValidatorInfo,
rewards_ctxt: &RewardsAndPenaltiesContext, rewards_ctxt: &RewardsAndPenaltiesContext,
@@ -349,8 +348,11 @@ fn process_single_reward_and_penalty(
spec, spec,
)?; )?;
balance.safe_add_assign(delta.rewards)?; if delta.rewards != 0 || delta.penalties != 0 {
*balance = balance.saturating_sub(delta.penalties); let balance = balance.make_mut()?;
balance.safe_add_assign(delta.rewards)?;
*balance = balance.saturating_sub(delta.penalties);
}
Ok(()) Ok(())
} }
@@ -449,7 +451,7 @@ impl RewardsAndPenaltiesContext {
} }
fn process_single_registry_update( fn process_single_registry_update(
validator: &mut Validator, validator: &mut Cow<Validator>,
validator_info: &ValidatorInfo, validator_info: &ValidatorInfo,
exit_cache: &mut ExitCache, exit_cache: &mut ExitCache,
activation_queue: &BTreeSet<usize>, activation_queue: &BTreeSet<usize>,
@@ -460,7 +462,7 @@ fn process_single_registry_update(
let current_epoch = state_ctxt.current_epoch; let current_epoch = state_ctxt.current_epoch;
if validator.is_eligible_for_activation_queue(spec) { if validator.is_eligible_for_activation_queue(spec) {
validator.mutable.activation_eligibility_epoch = current_epoch.safe_add(1)?; validator.make_mut()?.mutable.activation_eligibility_epoch = current_epoch.safe_add(1)?;
} }
if validator.is_active_at(current_epoch) if validator.is_active_at(current_epoch)
@@ -470,7 +472,8 @@ fn process_single_registry_update(
} }
if activation_queue.contains(&validator_info.index) { if activation_queue.contains(&validator_info.index) {
validator.mutable.activation_epoch = spec.compute_activation_exit_epoch(current_epoch)?; validator.make_mut()?.mutable.activation_epoch =
spec.compute_activation_exit_epoch(current_epoch)?;
} }
// Caching: add to speculative activation queue for next epoch. // Caching: add to speculative activation queue for next epoch.
@@ -485,7 +488,7 @@ fn process_single_registry_update(
} }
fn initiate_validator_exit( fn initiate_validator_exit(
validator: &mut Validator, validator: &mut Cow<Validator>,
exit_cache: &mut ExitCache, exit_cache: &mut ExitCache,
state_ctxt: &StateContext, state_ctxt: &StateContext,
spec: &ChainSpec, spec: &ChainSpec,
@@ -506,6 +509,7 @@ fn initiate_validator_exit(
exit_queue_epoch.safe_add_assign(1)?; exit_queue_epoch.safe_add_assign(1)?;
} }
let validator = validator.make_mut()?;
validator.mutable.exit_epoch = exit_queue_epoch; validator.mutable.exit_epoch = exit_queue_epoch;
validator.mutable.withdrawable_epoch = validator.mutable.withdrawable_epoch =
exit_queue_epoch.safe_add(spec.min_validator_withdrawability_delay)?; exit_queue_epoch.safe_add(spec.min_validator_withdrawability_delay)?;
@@ -538,7 +542,7 @@ impl SlashingsContext {
} }
fn process_single_slashing( fn process_single_slashing(
balance: &mut u64, balance: &mut Cow<u64>,
validator: &Validator, validator: &Validator,
slashings_ctxt: &SlashingsContext, slashings_ctxt: &SlashingsContext,
state_ctxt: &StateContext, state_ctxt: &StateContext,
@@ -556,7 +560,7 @@ fn process_single_slashing(
.safe_div(state_ctxt.total_active_balance)? .safe_div(state_ctxt.total_active_balance)?
.safe_mul(increment)?; .safe_mul(increment)?;
*balance = balance.saturating_sub(penalty); *balance.make_mut()? = balance.saturating_sub(penalty);
} }
Ok(()) Ok(())
} }
@@ -580,7 +584,7 @@ impl EffectiveBalancesContext {
#[allow(clippy::too_many_arguments)] #[allow(clippy::too_many_arguments)]
fn process_single_effective_balance_update( fn process_single_effective_balance_update(
balance: u64, balance: u64,
validator: &mut Validator, validator: &mut Cow<Validator>,
validator_info: &ValidatorInfo, validator_info: &ValidatorInfo,
next_epoch_total_active_balance: &mut u64, next_epoch_total_active_balance: &mut u64,
next_epoch_cache: &mut PreEpochCache, next_epoch_cache: &mut PreEpochCache,
@@ -610,7 +614,7 @@ fn process_single_effective_balance_update(
} }
if new_effective_balance != old_effective_balance { if new_effective_balance != old_effective_balance {
validator.mutable.effective_balance = new_effective_balance; validator.make_mut()?.mutable.effective_balance = new_effective_balance;
// Update progressive balances cache for the *current* epoch, which will soon become the // Update progressive balances cache for the *current* epoch, which will soon become the
// previous epoch once the epoch transition completes. // previous epoch once the epoch transition completes.