Fix clippy errors on tests (#2160)

## Issue Addressed

There are some clippy error on tests.


## Proposed Changes

Enable clippy check on tests and fix the errors. 💪

beacon_node/eth2_libp2p/src/discovery/mod.rs

@@ -964,8 +964,10 @@ mod tests {
 
     async fn build_discovery() -> Discovery<E> {
         let keypair = libp2p::identity::Keypair::generate_secp256k1();
-        let mut config = NetworkConfig::default();
-        config.discovery_port = unused_port();
+        let config = NetworkConfig {
+            discovery_port: unused_port(),
+            ..Default::default()
+        };
         let enr_key: CombinedKey = CombinedKey::from_libp2p(&keypair).unwrap();
         let enr: Enr = build_enr::<E>(&enr_key, &config, EnrForkId::default()).unwrap();
         let log = build_log(slog::Level::Debug, false);
@@ -1055,7 +1057,7 @@ mod tests {
         discovery.queued_queries.push_back(QueryType::FindPeers);
         discovery
             .queued_queries
-            .push_back(QueryType::Subnet(subnet_query.clone()));
+            .push_back(QueryType::Subnet(subnet_query));
         // Process Subnet query and FindPeers afterwards.
         assert!(discovery.process_queue());
     }
@@ -1101,7 +1103,7 @@ mod tests {
         // Unwanted enr for the given grouped query
         let enr3 = make_enr(vec![3]);
 
-        let enrs: Vec<Enr> = vec![enr1.clone(), enr2.clone(), enr3.clone()];
+        let enrs: Vec<Enr> = vec![enr1.clone(), enr2, enr3];
         let results = discovery
             .process_completed_queries(QueryResult(query, Ok(enrs)))
             .unwrap();

beacon_node/eth2_libp2p/src/peer_manager/peerdb.rs

@@ -645,6 +645,7 @@ mod tests {
     }
 
     #[test]
+    #[allow(clippy::float_cmp)]
     fn test_peer_connected_successfully() {
         let mut pdb = get_db();
         let random_peer = PeerId::random();
@@ -745,7 +746,7 @@ mod tests {
         assert!(the_best.is_some());
         // Consistency check
         let best_peers = pdb.best_peers_by_status(PeerInfo::is_connected);
-        assert_eq!(the_best, best_peers.iter().next().map(|p| p.0));
+        assert_eq!(the_best.unwrap(), best_peers.get(0).unwrap().0);
     }
 
     #[test]
@@ -839,7 +840,7 @@ mod tests {
         pdb.notify_disconnect(&random_peer2);
         pdb.disconnect_and_ban(&random_peer3);
         pdb.notify_disconnect(&random_peer3);
-        pdb.connect_ingoing(&random_peer, multiaddr.clone(), None);
+        pdb.connect_ingoing(&random_peer, multiaddr, None);
         assert_eq!(pdb.disconnected_peers, pdb.disconnected_peers().count());
         assert_eq!(
             pdb.banned_peers_count.banned_peers(),
@@ -1021,10 +1022,11 @@ mod tests {
     }
 
     #[test]
+    #[allow(clippy::float_cmp)]
     fn test_trusted_peers_score() {
         let trusted_peer = PeerId::random();
         let log = build_log(slog::Level::Debug, false);
-        let mut pdb: PeerDB<M> = PeerDB::new(vec![trusted_peer.clone()], &log);
+        let mut pdb: PeerDB<M> = PeerDB::new(vec![trusted_peer], &log);
 
         pdb.connect_ingoing(&trusted_peer, "/ip4/0.0.0.0".parse().unwrap(), None);
 

beacon_node/eth2_libp2p/src/peer_manager/score.rs

@@ -346,6 +346,7 @@ mod tests {
     use super::*;
 
     #[test]
+    #[allow(clippy::float_cmp)]
     fn test_reputation_change() {
         let mut score = Score::default();
 
@@ -375,6 +376,7 @@ mod tests {
     }
 
     #[test]
+    #[allow(clippy::float_cmp)]
     fn test_ban_time() {
         let mut score = RealScore::default();
         let now = Instant::now();
@@ -402,6 +404,7 @@ mod tests {
     }
 
     #[test]
+    #[allow(clippy::float_cmp)]
     fn test_ignored_gossipsub_score() {
         let mut score = Score::default();
         score.update_gossipsub_score(GOSSIPSUB_GREYLIST_THRESHOLD, true);