Kintsugi review comments (#2831)

* Fix makefile

* Return on invalid finalized block

* Fix todo in gossip scoring

* Require --merge for --fee-recipient

* Bump eth2_serde_utils

* Change schema versions

* Swap hash/uint256 test_random impls

* Use default for ExecutionPayload::empty

* Check for DBs before removing

* Remove kintsugi docker image

* Fix CLI default value
This commit is contained in:
Paul Hauner
2021-11-30 09:32:53 +11:00
parent 82a81524e3
commit 1b56ebf85e
22 changed files with 57 additions and 114 deletions

View File

@@ -3281,6 +3281,9 @@ impl<T: BeaconChainTypes> BeaconChain<T> {
"Finalized block has an invalid execution payload.",
))
.map_err(BeaconChainError::InvalidFinalizedPayloadShutdownError)?;
// Exit now, the node is in an invalid state.
return Ok(());
}
// Due to race conditions, it's technically possible that the head we load here is