gnosis/lighthouse
1
0
Fork 0
mirror of https://github.com/sigp/lighthouse.git synced 2026-03-03 00:31:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix flaky reconstruction test (#8321)

Browse Source 
FIx flaky tests that depends on timing. Previously the test processes all 128 columns and expect reconstruction to happen after all columns are processed. There is a race here, and reconstruction could be triggered before all columns are processed.

I've updated the tests to process 64 columns, just enough for reconstruction and wait for 50ms for reconstruction to be triggered.

This PR requires the change made in https://github.com/sigp/lighthouse/pull/8194 for the test to pass consistently (blob count set to 1 for all blocks instead of random blob count between 0..max)


  


Co-Authored-By: Jimmy Chen <jchen.tc@gmail.com>

Co-Authored-By: Jimmy Chen <jimmy@sigmaprime.io>
This commit is contained in:
Jimmy Chen
2025-11-10 15:06:42 +11:00
committed by GitHub
parent 2c1f1c1605
commit 1bd4ac2113
1 changed files with 13 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
beacon_node/network/src/network_beacon_processor/tests.rs
View File

@@ -916,36 +916,29 @@ async fn data_column_reconstruction_at_deadline() {
.start_of(rig.next_block.slot())
.unwrap();
rig.chain
.slot_clock
.set_current_time(slot_start - rig.chain.spec.maximum_gossip_clock_disparity());
assert_eq!(
rig.chain.slot().unwrap(),
rig.next_block.slot() - 1,
"chain should be at the correct slot"
);
// We push the slot clock to 3 seconds into the slot, this is the deadline to trigger reconstruction.
let slot_duration = rig.chain.slot_clock.slot_duration().as_millis() as u64;
let reconstruction_deadline_millis =
(slot_duration * RECONSTRUCTION_DEADLINE.0) / RECONSTRUCTION_DEADLINE.1;
rig.chain
.slot_clock
.set_current_time(slot_start + Duration::from_secs(3));
.set_current_time(slot_start + Duration::from_millis(reconstruction_deadline_millis));
let num_data_columns = rig.next_data_columns.as_ref().map(|c| c.len()).unwrap_or(0);
for i in 0..num_data_columns {
let min_columns_for_reconstruction = E::number_of_columns() / 2;
for i in 0..min_columns_for_reconstruction {
rig.enqueue_gossip_data_columns(i);
rig.assert_event_journal_completes(&[WorkType::GossipDataColumnSidecar])
.await;
}
// Since we're at the reconstruction deadline, reconstruction should be triggered immediately
if num_data_columns > 0 {
rig.assert_event_journal_completes_with_timeout(
&[WorkType::ColumnReconstruction],
Duration::from_millis(50),
)
.await;
}
rig.assert_event_journal_with_timeout(
&[WorkType::ColumnReconstruction.into()],
Duration::from_millis(50),
false,
false,
)
.await;
}
// Test the column reconstruction is delayed for columns that arrive for a previous slot.