gnosis/lighthouse
1
0
Fork 0
mirror of https://github.com/sigp/lighthouse.git synced 2026-03-10 04:01:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do not filter validators by status if filter is an empty list (#7884)

Browse Source 
69d2feb12a/apis/beacon/states/validators.yaml (L128-L130) says we need to not filter if the filter is an empty list.


  Add a check for `statuses.is_empty()`.
This commit is contained in:
Daniel Knopik
2025-08-18 09:46:37 +02:00
committed by GitHub
parent 836c39efaa
commit 1fd7ead010
3 changed files with 39 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
beacon_node/http_api/src/validators.rs
View File

@@ -18,8 +18,18 @@ pub fn get_beacon_state_validators<T: BeaconChainTypes>(
|state, execution_optimistic, finalized| {
let epoch = state.current_epoch();
let far_future_epoch = chain.spec.far_future_epoch;
let ids_filter_set: Option<HashSet<&ValidatorId>> =
query_ids.as_ref().map(HashSet::from_iter);
// Map [] to None, indicating that no filtering should be applied (return all
// validators).
let ids_filter_set: Option<HashSet<&ValidatorId>> = query_ids
.as_ref()
.filter(|list| !list.is_empty())
.map(HashSet::from_iter);
let statuses_filter_set: Option<HashSet<&ValidatorStatus>> = query_statuses
.as_ref()
.filter(|list| !list.is_empty())
.map(HashSet::from_iter);
Ok((
state
@@ -42,10 +52,11 @@ pub fn get_beacon_state_validators<T: BeaconChainTypes>(
far_future_epoch,
);
let status_matches = query_statuses.as_ref().is_none_or(|statuses| {
statuses.contains(&status)
|| statuses.contains(&status.superstatus())
});
let status_matches =
statuses_filter_set.as_ref().is_none_or(|statuses| {
statuses.contains(&status)
|| statuses.contains(&status.superstatus())
});
if status_matches {
Some(ValidatorData {