Simplify hashing in shuffling (#6483)

* Simplify hashing in shuffling

* Fix benchmark deps

* Check benchmarks when linting

consensus/swap_or_not_shuffle/Cargo.toml

@@ -18,4 +18,3 @@ fixed_bytes = { workspace = true }
 
 [features]
 arbitrary = ["alloy-primitives/arbitrary"]
-getrandom = ["alloy-primitives/getrandom"]

consensus/swap_or_not_shuffle/src/shuffle_list.rs

@@ -45,7 +45,7 @@ impl Buf {
 
     /// Hash the entire buffer.
     fn hash(&self) -> Hash256 {
-        Hash256::from_slice(&hash_fixed(&self.0))
+        Hash256::from(hash_fixed(&self.0))
     }
 }
 

consensus/types/Cargo.toml

@@ -9,7 +9,7 @@ name = "benches"
 harness = false
 
 [dependencies]
-alloy-primitives = { workspace = true, features = ["rlp", "getrandom"] }
+alloy-primitives = { workspace = true }
 merkle_proof = { workspace = true }
 bls = { workspace = true, features = ["arbitrary"] }
 kzg = { workspace = true }

consensus/types/benches/benches.rs

@@ -78,7 +78,7 @@ fn all_benches(c: &mut Criterion) {
                 || (bytes.clone(), spec.clone()),
                 |(bytes, spec)| {
                     let state: BeaconState<MainnetEthSpec> =
-                        BeaconState::from_ssz_bytes(&bytes, &spec).expect("should decode");
+                        BeaconState::from_ssz_bytes(bytes, spec).expect("should decode");
                     black_box(state)
                 },
                 BatchSize::SmallInput,