gnosis/lighthouse
1
0
Fork 0
mirror of https://github.com/sigp/lighthouse.git synced 2026-03-21 05:44:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use slice.is_sorted now that it's stable (#7507)

Browse Source 
Use slice.is_sorted which was stabilised in Rust 1.82.0

I thought there would be more places we could use this, but it seems we often want to check strict monotonicity (i.e. sorted + no duplicates)
This commit is contained in:
Michael Sproul
2025-05-22 12:14:46 +10:00
committed by GitHub
parent e29b607257
commit 2e96e9769b
1 changed files with 2 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
beacon_node/beacon_chain/src/test_utils.rs
View File

@@ -2671,10 +2671,7 @@ where
mut latest_block_hash: Option<SignedBeaconBlockHash>, mut latest_block_hash: Option<SignedBeaconBlockHash>,
sync_committee_strategy: SyncCommitteeStrategy, sync_committee_strategy: SyncCommitteeStrategy,
) -> AddBlocksResult<E> { ) -> AddBlocksResult<E> {
assert!( assert!(slots.is_sorted(), "Slots have to be in ascending order");
slots.windows(2).all(|w| w[0] <= w[1]),
"Slots have to be sorted"
); // slice.is_sorted() isn't stabilized at the moment of writing this
let mut block_hash_from_slot: HashMap<Slot, SignedBeaconBlockHash> = HashMap::new(); let mut block_hash_from_slot: HashMap<Slot, SignedBeaconBlockHash> = HashMap::new();
let mut state_hash_from_slot: HashMap<Slot, BeaconStateHash> = HashMap::new(); let mut state_hash_from_slot: HashMap<Slot, BeaconStateHash> = HashMap::new();
for slot in slots { for slot in slots {
@@ -2714,10 +2711,7 @@ where
mut latest_block_hash: Option<SignedBeaconBlockHash>, mut latest_block_hash: Option<SignedBeaconBlockHash>,
sync_committee_strategy: SyncCommitteeStrategy, sync_committee_strategy: SyncCommitteeStrategy,
) -> AddBlocksResult<E> { ) -> AddBlocksResult<E> {
assert!( assert!(slots.is_sorted(), "Slots have to be in ascending order");
slots.windows(2).all(|w| w[0] <= w[1]),
"Slots have to be sorted"
); // slice.is_sorted() isn't stabilized at the moment of writing this
let mut block_hash_from_slot: HashMap<Slot, SignedBeaconBlockHash> = HashMap::new(); let mut block_hash_from_slot: HashMap<Slot, SignedBeaconBlockHash> = HashMap::new();
let mut state_hash_from_slot: HashMap<Slot, BeaconStateHash> = HashMap::new(); let mut state_hash_from_slot: HashMap<Slot, BeaconStateHash> = HashMap::new();
for slot in slots { for slot in slots {