gnosis/lighthouse
1
0
Fork 0
mirror of https://github.com/sigp/lighthouse.git synced 2026-05-30 20:57:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Rust 1.54.0 lints (#2483)

Browse Source 
## Issue Addressed

N/A

## Proposed Changes

- Removing a bunch of unnecessary references
- Updated `Error::VariantError` to `Error::Variant`
- There were additional enum variant lints that I ignored, because I thought our variant names were fine
- removed `MonitoredValidator`'s `pubkey` field, because I couldn't find it used anywhere. It looks like we just use the string version of the pubkey (the `id` field) if there is no index

## Additional Info



Co-authored-by: realbigsean <seananderson33@gmail.com>
This commit is contained in:
realbigsean
2021-07-30 01:11:47 +00:00
parent 8efd9fc324
commit 303deb9969
104 changed files with 307 additions and 313 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
crypto/eth2_wallet/tests/json.rs
View File

@@ -1,7 +1,7 @@
use eth2_wallet::{Error, KeystoreError, Wallet};
fn assert_bad_json(json: &str) {
match Wallet::from_json_str(&json) {
match Wallet::from_json_str(json) {
Err(Error::KeystoreError(KeystoreError::InvalidJson(_))) => {}
_ => panic!("expected invalid json error"),
}
@@ -48,7 +48,7 @@ fn additional_top_level_param() {
}
"#;
assert_bad_json(&vector);
assert_bad_json(vector);
}
#[test]
@@ -86,7 +86,7 @@ fn missing_top_level_param() {
}
"#;
assert_bad_json(&vector);
assert_bad_json(vector);
}
#[test]
@@ -125,7 +125,7 @@ fn bad_version() {
}
"#;
assert_bad_json(&vector);
assert_bad_json(vector);
}
#[test]
@@ -164,7 +164,7 @@ fn bad_uuid() {
}
"#;
assert_bad_json(&vector);
assert_bad_json(vector);
}
#[test]
@@ -203,7 +203,7 @@ fn bad_type() {
}
"#;
assert_bad_json(&vector);
assert_bad_json(vector);
}
#[test]
@@ -242,5 +242,5 @@ fn more_that_u32_nextaccount() {
}
"#;
assert_bad_json(&vector);
assert_bad_json(vector);
}