Use all attestation subnets (#1257)

* Update `milagro_bls` to new release (#1183)

* Update milagro_bls to new release

Signed-off-by: Kirk Baird <baird.k@outlook.com>

* Tidy up fake cryptos

Signed-off-by: Kirk Baird <baird.k@outlook.com>

* move SecretHash to bls and put plaintext back

Signed-off-by: Kirk Baird <baird.k@outlook.com>

* Update v0.12.0 to v0.12.1

* Add compute_subnet_for_attestation

* Replace CommitteeIndex topic with Attestation

* Fix warnings

* Fix attestation service tests

* fmt

* Appease clippy

* return error from validator_subscriptions

* move state out of loop

* Fix early break on error

* Get state from slot clock

* Fix beacon state in attestation tests

* Add failing test for lookahead > 1

* Minor change

* Address some review comments

* Add subnet verification to beacon chain

* Move subnet verification to processor

* Pass committee_count_at_slot to ValidatorDuty and ValidatorSubscription

* Pass subnet id for publishing attestations

* Fix attestation service tests

* Fix more tests

* Fix fork choice test

* Remove unused code

* Remove more unused and expensive code

Co-authored-by: Kirk Baird <baird.k@outlook.com>
Co-authored-by: Michael Sproul <michael@sigmaprime.io>
Co-authored-by: Age Manning <Age@AgeManning.com>
Co-authored-by: Paul Hauner <paul@paulhauner.com>

common/remote_beacon_node/src/lib.rs

@@ -12,7 +12,7 @@ use std::time::Duration;
 use types::{
     Attestation, AttestationData, AttesterSlashing, BeaconBlock, BeaconState, CommitteeIndex,
     Epoch, EthSpec, Fork, Hash256, ProposerSlashing, PublicKey, PublicKeyBytes, Signature,
-    SignedAggregateAndProof, SignedBeaconBlock, Slot,
+    SignedAggregateAndProof, SignedBeaconBlock, Slot, SubnetId,
 };
 use url::Url;
 
@@ -227,7 +227,7 @@ impl<E: EthSpec> Validator<E> {
     /// Posts a list of attestations to the beacon node, expecting it to verify it and publish it to the network.
     pub async fn publish_attestations(
         &self,
-        attestation: Vec<Attestation<E>>,
+        attestation: Vec<(Attestation<E>, SubnetId)>,
     ) -> Result<PublishStatus, Error> {
         let client = self.0.clone();
         let url = self.url("attestations")?;

common/rest_types/src/validator.rs

@@ -22,6 +22,8 @@ pub struct ValidatorDutyBase<T> {
     pub attestation_committee_index: Option<CommitteeIndex>,
     /// The position of the validator in the committee.
     pub attestation_committee_position: Option<usize>,
+    /// The committee count at `attestation_slot`.
+    pub committee_count_at_slot: Option<u64>,
     /// The slots in which a validator must propose a block (can be empty).
     pub block_proposal_slots: Vec<Slot>,
     /// This provides the modulo: `max(1, len(committee) // TARGET_AGGREGATORS_PER_COMMITTEE)`
@@ -66,6 +68,8 @@ pub struct ValidatorSubscription {
     pub attestation_committee_index: CommitteeIndex,
     /// The slot in which to subscribe.
     pub slot: Slot,
+    /// Committee count at slot to subscribe.
+    pub committee_count_at_slot: u64,
     /// If true, the validator is an aggregator and the beacon node should aggregate attestations
     /// for this slot.
     pub is_aggregator: bool,