Remove TestRandom (#9006)

We  have a legacy `TestRandom` trait which generates random types for testing and fuzzing.
This function overlaps with `arbitrary` which is used very commonly in the ecosystem.


  Remove `TestRandom` and generate random type instances using `Arbitrary`.


Co-Authored-By: Mac L <mjladson@pm.me>

Co-Authored-By: Michael Sproul <michael@sigmaprime.io>

beacon_node/builder_client/Cargo.toml

@@ -16,5 +16,7 @@ serde = { workspace = true }
 serde_json = { workspace = true }
 
 [dev-dependencies]
+arbitrary = { workspace = true }
 mockito = { workspace = true }
 tokio = { workspace = true }
+types = { workspace = true, features = ["arbitrary"] }

beacon_node/builder_client/src/lib.rs

@@ -540,10 +540,10 @@ impl BuilderHttpClient {
 #[cfg(test)]
 mod tests {
     use super::*;
+    use arbitrary::Arbitrary;
     use bls::Signature;
     use eth2::types::MainnetEthSpec;
     use eth2::types::builder::{BuilderBid, BuilderBidFulu};
-    use eth2::types::test_utils::{SeedableRng, TestRandom, XorShiftRng};
     use mockito::{Matcher, Server, ServerGuard};
 
     type E = MainnetEthSpec;
@@ -689,12 +689,12 @@ mod tests {
     }
 
     fn fulu_signed_builder_bid() -> ForkVersionedResponse<SignedBuilderBid<E>> {
-        let rng = &mut XorShiftRng::from_seed([42; 16]);
+        let mut u = types::test_utils::test_unstructured();
         ForkVersionedResponse {
             version: ForkName::Fulu,
             metadata: EmptyMetadata {},
             data: SignedBuilderBid {
-                message: BuilderBid::Fulu(BuilderBidFulu::random_for_test(rng)),
+                message: BuilderBid::Fulu(BuilderBidFulu::arbitrary(&mut u).unwrap()),
                 signature: Signature::empty(),
             },
         }