From 366fb0ee0dc3d87eeb6995847f05ecab8e48d11f Mon Sep 17 00:00:00 2001 From: Jimmy Chen Date: Fri, 19 Sep 2025 22:58:46 +1000 Subject: [PATCH] Always upload sim test logs (#8082) This CI job failed https://github.com/sigp/lighthouse/actions/runs/17815533375/job/50647915897 But we lost the logs because they aren't uploaded when the job fails. This PR changes the step to always upload job, even in the case of failure. Co-Authored-By: Jimmy Chen --- .github/workflows/test-suite.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/test-suite.yml b/.github/workflows/test-suite.yml index 59a045c7d3..0201bf9ae3 100644 --- a/.github/workflows/test-suite.yml +++ b/.github/workflows/test-suite.yml @@ -225,6 +225,7 @@ jobs: TEST_FEATURES: portable CI_LOGGER_DIR: ${{ runner.temp }}/network_test_logs - name: Upload logs + if: always() uses: actions/upload-artifact@v4 with: name: network_test_logs @@ -328,6 +329,7 @@ jobs: - name: Run a basic beacon chain sim that starts from Deneb run: cargo run --release --bin simulator basic-sim --disable-stdout-logging --log-dir ${{ runner.temp }}/basic_simulator_logs - name: Upload logs + if: always() uses: actions/upload-artifact@v4 with: name: basic_simulator_logs @@ -349,6 +351,7 @@ jobs: - name: Run a beacon chain sim which tests VC fallback behaviour run: cargo run --release --bin simulator fallback-sim --disable-stdout-logging --log-dir ${{ runner.temp }}/fallback_simulator_logs - name: Upload logs + if: always() uses: actions/upload-artifact@v4 with: name: fallback_simulator_logs