Update to spec v1.0.0-rc.0 and BLSv4 (#1765)

## Issue Addressed

Closes #1504 
Closes #1505
Replaces #1703
Closes #1707

## Proposed Changes

* Update BLST and Milagro to versions compatible with BLSv4 spec
* Update Lighthouse to spec v1.0.0-rc.0, and update EF test vectors
* Use the v1.0.0 constants for `MainnetEthSpec`.
* Rename `InteropEthSpec` -> `V012LegacyEthSpec`
    * Change all constants to suit the mainnet `v0.12.3` specification (i.e., Medalla).
* Deprecate the `--spec` flag for the `lighthouse` binary
    * This value is now obtained from the `config_name` field of the `YamlConfig`.
        * Built in testnet YAML files have been updated.
    * Ignore the `--spec` value, if supplied, log a warning that it will be deprecated
    * `lcli` still has the spec flag, that's fine because it's dev tooling.
* Remove the `E: EthSpec` from `YamlConfig`
    * This means we need to deser the genesis `BeaconState` on-demand, but this is fine.
* Swap the old "minimal", "mainnet" strings over to the new `EthSpecId` enum.
* Always require a `CONFIG_NAME` field in `YamlConfig` (it used to have a default).

## Additional Info

Lots of breaking changes, do not merge! ~~We will likely need a Lighthouse v0.4.0 branch, and possibly a long-term v0.3.0 branch to keep Medalla alive~~.

Co-authored-by: Kirk Baird <baird.k@outlook.com>
Co-authored-by: Paul Hauner <paul@paulhauner.com>

lcli/Cargo.toml

@@ -1,7 +1,7 @@
 [package]
 name = "lcli"
 description = "Lighthouse CLI (modeled after zcli)"
-version = "0.3.1"
+version = "0.3.2"
 authors = ["Paul Hauner <paul@paulhauner.com>"]
 edition = "2018"
 

lcli/src/eth1_genesis.rs

@@ -2,6 +2,7 @@ use clap::ArgMatches;
 use environment::Environment;
 use eth2_testnet_config::Eth2TestnetConfig;
 use genesis::{Eth1Config, Eth1GenesisService};
+use ssz::Encode;
 use std::path::PathBuf;
 use std::time::Duration;
 use types::EthSpec;
@@ -24,8 +25,7 @@ pub fn run<T: EthSpec>(mut env: Environment<T>, matches: &ArgMatches<'_>) -> Res
                 .expect("should locate home directory")
         });
 
-    let mut eth2_testnet_config: Eth2TestnetConfig<T> =
-        Eth2TestnetConfig::load(testnet_dir.clone())?;
+    let mut eth2_testnet_config = Eth2TestnetConfig::load(testnet_dir.clone())?;
 
     let spec = eth2_testnet_config
         .yaml_config
@@ -35,7 +35,7 @@ pub fn run<T: EthSpec>(mut env: Environment<T>, matches: &ArgMatches<'_>) -> Res
         .ok_or_else(|| {
             format!(
                 "The loaded config is not compatible with the {} spec",
-                &env.core_context().eth2_config.spec_constants
+                &env.core_context().eth2_config.eth_spec_id
             )
         })?;
 
@@ -51,10 +51,10 @@ pub fn run<T: EthSpec>(mut env: Environment<T>, matches: &ArgMatches<'_>) -> Res
 
     env.runtime().block_on(async {
         let _ = genesis_service
-            .wait_for_genesis_state(ETH1_GENESIS_UPDATE_INTERVAL, spec)
+            .wait_for_genesis_state::<T>(ETH1_GENESIS_UPDATE_INTERVAL, spec)
             .await
             .map(move |genesis_state| {
-                eth2_testnet_config.genesis_state = Some(genesis_state);
+                eth2_testnet_config.genesis_state_bytes = Some(genesis_state.as_ssz_bytes());
                 eth2_testnet_config.force_write_to_file(testnet_dir)
             })
             .map_err(|e| format!("Failed to find genesis: {}", e))?;

lcli/src/interop_genesis.rs

@@ -3,6 +3,7 @@ use clap_utils::parse_ssz_optional;
 use environment::Environment;
 use eth2_testnet_config::Eth2TestnetConfig;
 use genesis::interop_genesis_state;
+use ssz::Encode;
 use std::path::PathBuf;
 use std::time::{SystemTime, UNIX_EPOCH};
 use types::{test_utils::generate_deterministic_keypairs, EthSpec};
@@ -35,8 +36,7 @@ pub fn run<T: EthSpec>(mut env: Environment<T>, matches: &ArgMatches) -> Result<
                 .expect("should locate home directory")
         });
 
-    let mut eth2_testnet_config: Eth2TestnetConfig<T> =
-        Eth2TestnetConfig::load(testnet_dir.clone())?;
+    let mut eth2_testnet_config = Eth2TestnetConfig::load(testnet_dir.clone())?;
 
     let mut spec = eth2_testnet_config
         .yaml_config
@@ -46,7 +46,7 @@ pub fn run<T: EthSpec>(mut env: Environment<T>, matches: &ArgMatches) -> Result<
         .ok_or_else(|| {
             format!(
                 "The loaded config is not compatible with the {} spec",
-                &env.core_context().eth2_config.spec_constants
+                &env.core_context().eth2_config.eth_spec_id
             )
         })?;
 
@@ -55,9 +55,9 @@ pub fn run<T: EthSpec>(mut env: Environment<T>, matches: &ArgMatches) -> Result<
     }
 
     let keypairs = generate_deterministic_keypairs(validator_count);
-    let genesis_state = interop_genesis_state(&keypairs, genesis_time, &spec)?;
+    let genesis_state = interop_genesis_state::<T>(&keypairs, genesis_time, &spec)?;
 
-    eth2_testnet_config.genesis_state = Some(genesis_state);
+    eth2_testnet_config.genesis_state_bytes = Some(genesis_state.as_ssz_bytes());
     eth2_testnet_config.force_write_to_file(testnet_dir)?;
 
     Ok(())

lcli/src/main.rs

@@ -20,9 +20,12 @@ use parse_hex::run_parse_hex;
 use std::fs::File;
 use std::path::PathBuf;
 use std::process;
+use std::str::FromStr;
 use std::time::{SystemTime, UNIX_EPOCH};
 use transition_blocks::run_transition_blocks;
-use types::{test_utils::TestingBeaconStateBuilder, EthSpec, MainnetEthSpec, MinimalEthSpec};
+use types::{
+    test_utils::TestingBeaconStateBuilder, EthSpec, EthSpecId, MainnetEthSpec, MinimalEthSpec,
+};
 
 fn main() {
     simple_logger::SimpleLogger::new()
@@ -482,25 +485,21 @@ fn main() {
         )
         .get_matches();
 
-    macro_rules! run_with_spec {
-        ($env_builder: expr) => {
-            match run($env_builder, &matches) {
-                Ok(()) => process::exit(0),
-                Err(e) => {
-                    println!("Failed to run lcli: {}", e);
-                    process::exit(1)
-                }
-            }
-        };
-    }
+    let result = matches
+        .value_of("spec")
+        .ok_or_else(|| "Missing --spec flag".to_string())
+        .and_then(FromStr::from_str)
+        .and_then(|eth_spec_id| match eth_spec_id {
+            EthSpecId::Minimal => run(EnvironmentBuilder::minimal(), &matches),
+            EthSpecId::Mainnet => run(EnvironmentBuilder::mainnet(), &matches),
+            EthSpecId::V012Legacy => run(EnvironmentBuilder::v012_legacy(), &matches),
+        });
 
-    match matches.value_of("spec") {
-        Some("minimal") => run_with_spec!(EnvironmentBuilder::minimal()),
-        Some("mainnet") => run_with_spec!(EnvironmentBuilder::mainnet()),
-        Some("interop") => run_with_spec!(EnvironmentBuilder::interop()),
-        spec => {
-            // This path should be unreachable due to slog having a `default_value`
-            unreachable!("Unknown spec configuration: {:?}", spec);
+    match result {
+        Ok(()) => process::exit(0),
+        Err(e) => {
+            println!("Failed to run lcli: {}", e);
+            process::exit(1)
         }
     }
 }

lcli/src/new_testnet.rs

@@ -51,11 +51,11 @@ pub fn run<T: EthSpec>(matches: &ArgMatches) -> Result<(), String> {
         spec.genesis_fork_version = v;
     }
 
-    let testnet: Eth2TestnetConfig<T> = Eth2TestnetConfig {
+    let testnet = Eth2TestnetConfig {
         deposit_contract_address: format!("{:?}", deposit_contract_address),
         deposit_contract_deploy_block,
         boot_enr: Some(vec![]),
-        genesis_state: None,
+        genesis_state_bytes: None,
         yaml_config: Some(YamlConfig::from_spec::<T>(&spec)),
     };