Update to Spec v0.10 (#817)

* Start updating types

* WIP

* Signature hacking

* Existing EF tests passing with fake_crypto

* Updates

* Delete outdated API spec

* The refactor continues

* It compiles

* WIP test fixes

* All release tests passing bar genesis state parsing

* Update and test YamlConfig

* Update to spec v0.10 compatible BLS

* Updates to BLS EF tests

* Add EF test for AggregateVerify

And delete unused hash2curve tests for uncompressed points

* Update EF tests to v0.10.1

* Use optional block root correctly in block proc

* Use genesis fork in deposit domain. All tests pass

* Cargo fmt

* Fast aggregate verify test

* Update REST API docs

* Cargo fmt

* Fix unused import

* Bump spec tags to v0.10.1

* Add `seconds_per_eth1_block` to chainspec

* Update to timestamp based eth1 voting scheme

* Return None from `get_votes_to_consider` if block cache is empty

* Handle overflows in `is_candidate_block`

* Revert to failing tests

* Fix eth1 data sets test

* Choose default vote according to spec

* Fix collect_valid_votes tests

* Fix `get_votes_to_consider` to choose all eligible blocks

* Uncomment winning_vote tests

* Add comments; remove unused code

* Reduce seconds_per_eth1_block for simulation

* Addressed review comments

* Add test for default vote case

* Fix logs

* Remove unused functions

* Meter default eth1 votes

* Fix comments

* Address review comments; remove unused dependency

* Disable/delete two outdated tests

* Bump eth1 default vote warn to error

* Delete outdated eth1 test

Co-authored-by: Pawan Dhananjay <pawandhananjay@gmail.com>

beacon_node/beacon_chain/src/test_utils.rs

@@ -16,10 +16,9 @@ use store::{
     migrate::{BlockingMigrator, NullMigrator},
     DiskStore, MemoryStore, Migrate, Store,
 };
-use tree_hash::{SignedRoot, TreeHash};
 use types::{
-    AggregateSignature, Attestation, BeaconBlock, BeaconState, BitList, ChainSpec, Domain, EthSpec,
-    Hash256, Keypair, SecretKey, Signature, Slot,
+    AggregateSignature, Attestation, BeaconState, BitList, ChainSpec, Domain, EthSpec, Hash256,
+    Keypair, SecretKey, Signature, SignedBeaconBlock, SignedRoot, Slot,
 };
 
 pub use crate::persisted_beacon_chain::{PersistedBeaconChain, BEACON_CHAIN_DB_KEY};
@@ -279,7 +278,7 @@ where
         mut state: BeaconState<E>,
         slot: Slot,
         block_strategy: BlockStrategy,
-    ) -> (BeaconBlock<E>, BeaconState<E>) {
+    ) -> (SignedBeaconBlock<E>, BeaconState<E>) {
         if slot < state.slot {
             panic!("produce slot cannot be prior to the state slot");
         }
@@ -308,24 +307,19 @@ where
 
         let randao_reveal = {
             let epoch = slot.epoch(E::slots_per_epoch());
-            let message = epoch.tree_hash_root();
             let domain = self.spec.get_domain(epoch, Domain::Randao, fork);
-            Signature::new(&message, domain, sk)
+            let message = epoch.signing_root(domain);
+            Signature::new(message.as_bytes(), sk)
         };
 
-        let (mut block, state) = self
+        let (block, state) = self
             .chain
             .produce_block_on_state(state, slot, randao_reveal)
             .expect("should produce block");
 
-        block.signature = {
-            let message = block.signed_root();
-            let epoch = block.slot.epoch(E::slots_per_epoch());
-            let domain = self.spec.get_domain(epoch, Domain::BeaconProposer, fork);
-            Signature::new(&message, domain, sk)
-        };
+        let signed_block = block.sign(sk, &state.fork, &self.spec);
 
-        (block, state)
+        (signed_block, state)
     }
 
     /// Adds attestations to the `BeaconChain` operations pool and fork choice.
@@ -407,18 +401,17 @@ where
                                 .expect("should be able to set aggregation bits");
 
                             let signature = {
-                                let message = data.tree_hash_root();
-
                                 let domain = spec.get_domain(
                                     data.target.epoch,
                                     Domain::BeaconAttester,
                                     fork,
                                 );
 
+                                let message = data.signing_root(domain);
+
                                 let mut agg_sig = AggregateSignature::new();
                                 agg_sig.add(&Signature::new(
-                                    &message,
-                                    domain,
+                                    message.as_bytes(),
                                     self.get_sk(*validator_index),
                                 ));
 
@@ -464,7 +457,7 @@ where
             .head()
             .expect("should get head")
             .beacon_block
-            .slot;
+            .slot();
 
         // Move to the next slot so we may produce some more blocks on the head.
         self.advance_slot();