From 393782f632d14064acf0bcda76f3f495215d03ff Mon Sep 17 00:00:00 2001 From: Michael Sproul Date: Wed, 22 Jul 2020 07:34:30 +0000 Subject: [PATCH] Prefer viable nightly Rust builds for CI (#1379) ## Proposed Changes CI is failing on PRs because of a regression in nightly Rust. This change forces `rustup` to install a version of the nightly compiler that can at least build `rustfmt`, which should reduce the frequency of this happening. ## Additional Info Example failing run: https://github.com/sigp/lighthouse/runs/896694659 Alternatively, we could allow CI to succeed even when `cargo-udeps` fails, but I think we should avoid doing that unless we really have to. --- .github/workflows/test-suite.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/test-suite.yml b/.github/workflows/test-suite.yml index bb984565e7..988c7aa29f 100644 --- a/.github/workflows/test-suite.yml +++ b/.github/workflows/test-suite.yml @@ -145,8 +145,8 @@ jobs: needs: cargo-fmt steps: - uses: actions/checkout@v1 - - name: Get latest version of nightly Rust - run: rustup update nightly + - name: Install a nightly compiler with rustfmt, as a kind of quality control + run: rustup toolchain install --component=rustfmt nightly - name: Install cargo-udeps run: cargo install cargo-udeps --locked - name: Run cargo udeps to identify unused crates in the dependency graph