mirror of
https://github.com/sigp/lighthouse.git
synced 2026-03-14 18:32:42 +00:00
Add a flag to disable peer scoring (#4135)
## Issue Addressed N/A ## Proposed Changes Adds a flag for disabling peer scoring. This is useful for local testing and testing small networks for new features.
This commit is contained in:
@@ -41,12 +41,14 @@ pub struct PeerDB<TSpec: EthSpec> {
|
||||
disconnected_peers: usize,
|
||||
/// Counts banned peers in total and per ip
|
||||
banned_peers_count: BannedPeersCount,
|
||||
/// Specifies if peer scoring is disabled.
|
||||
disable_peer_scoring: bool,
|
||||
/// PeerDB's logger
|
||||
log: slog::Logger,
|
||||
}
|
||||
|
||||
impl<TSpec: EthSpec> PeerDB<TSpec> {
|
||||
pub fn new(trusted_peers: Vec<PeerId>, log: &slog::Logger) -> Self {
|
||||
pub fn new(trusted_peers: Vec<PeerId>, disable_peer_scoring: bool, log: &slog::Logger) -> Self {
|
||||
// Initialize the peers hashmap with trusted peers
|
||||
let peers = trusted_peers
|
||||
.into_iter()
|
||||
@@ -56,6 +58,7 @@ impl<TSpec: EthSpec> PeerDB<TSpec> {
|
||||
log: log.clone(),
|
||||
disconnected_peers: 0,
|
||||
banned_peers_count: BannedPeersCount::default(),
|
||||
disable_peer_scoring,
|
||||
peers,
|
||||
}
|
||||
}
|
||||
@@ -704,7 +707,11 @@ impl<TSpec: EthSpec> PeerDB<TSpec> {
|
||||
warn!(log_ref, "Updating state of unknown peer";
|
||||
"peer_id" => %peer_id, "new_state" => ?new_state);
|
||||
}
|
||||
PeerInfo::default()
|
||||
if self.disable_peer_scoring {
|
||||
PeerInfo::trusted_peer_info()
|
||||
} else {
|
||||
PeerInfo::default()
|
||||
}
|
||||
});
|
||||
|
||||
// Ban the peer if the score is not already low enough.
|
||||
@@ -1300,7 +1307,7 @@ mod tests {
|
||||
|
||||
fn get_db() -> PeerDB<M> {
|
||||
let log = build_log(slog::Level::Debug, false);
|
||||
PeerDB::new(vec![], &log)
|
||||
PeerDB::new(vec![], false, &log)
|
||||
}
|
||||
|
||||
#[test]
|
||||
@@ -1999,7 +2006,7 @@ mod tests {
|
||||
fn test_trusted_peers_score() {
|
||||
let trusted_peer = PeerId::random();
|
||||
let log = build_log(slog::Level::Debug, false);
|
||||
let mut pdb: PeerDB<M> = PeerDB::new(vec![trusted_peer], &log);
|
||||
let mut pdb: PeerDB<M> = PeerDB::new(vec![trusted_peer], false, &log);
|
||||
|
||||
pdb.connect_ingoing(&trusted_peer, "/ip4/0.0.0.0".parse().unwrap(), None);
|
||||
|
||||
@@ -2018,4 +2025,28 @@ mod tests {
|
||||
Score::max_score().score()
|
||||
);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn test_disable_peer_scoring() {
|
||||
let peer = PeerId::random();
|
||||
let log = build_log(slog::Level::Debug, false);
|
||||
let mut pdb: PeerDB<M> = PeerDB::new(vec![], true, &log);
|
||||
|
||||
pdb.connect_ingoing(&peer, "/ip4/0.0.0.0".parse().unwrap(), None);
|
||||
|
||||
// Check trusted status and score
|
||||
assert!(pdb.peer_info(&peer).unwrap().is_trusted());
|
||||
assert_eq!(
|
||||
pdb.peer_info(&peer).unwrap().score().score(),
|
||||
Score::max_score().score()
|
||||
);
|
||||
|
||||
// Adding/Subtracting score should have no effect on a trusted peer
|
||||
add_score(&mut pdb, &peer, -50.0);
|
||||
|
||||
assert_eq!(
|
||||
pdb.peer_info(&peer).unwrap().score().score(),
|
||||
Score::max_score().score()
|
||||
);
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user