gnosis/lighthouse
1
0
Fork 0
mirror of https://github.com/sigp/lighthouse.git synced 2026-05-08 17:26:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

Clarify load_parent genesis behaviour

Browse Source
This commit is contained in:
Michael Sproul
2026-03-31 15:36:14 +11:00
parent e1dcd9e692
commit 3bc1d882f2
1 changed files with 24 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
beacon_node/beacon_chain/src/block_verification.rs
View File

@@ -1960,35 +1960,29 @@ fn load_parent<T: BeaconChainTypes, B: AsBlock<T::EthSpec>>(
// Post-Gloas we must also fetch a state with the correct payload status. If the current // Post-Gloas we must also fetch a state with the correct payload status. If the current
// block builds upon the payload of its parent block, then we know the parent block is FULL // block builds upon the payload of its parent block, then we know the parent block is FULL
// and we need to load the full state. // and we need to load the full state.
let (payload_status, parent_state_root) = let (payload_status, parent_state_root) = if parent_block.slot() == chain.spec.genesis_slot
if block.as_block().fork_name_unchecked().gloas_enabled()
&& let Ok(parent_bid_block_hash) = parent_block.payload_bid_block_hash()
{ {
if !parent_bid_block_hash.into_root().is_zero() // Genesis state is always pending, there is no such thing as a "genesis envelope".
// See: https://github.com/ethereum/consensus-specs/issues/5043
(StatePayloadStatus::Pending, parent_block.state_root())
} else if !block.as_block().fork_name_unchecked().gloas_enabled() {
// All pre-Gloas parent states are pending.
(StatePayloadStatus::Pending, parent_block.state_root())
} else if let Ok(parent_bid_block_hash) = parent_block.payload_bid_block_hash()
&& block.as_block().is_parent_block_full(parent_bid_block_hash) && block.as_block().is_parent_block_full(parent_bid_block_hash)
{ {
// Post-Gloas Full block case.
// TODO(gloas): loading the envelope here is not very efficient // TODO(gloas): loading the envelope here is not very efficient
let envelope = chain.store.get_payload_envelope(&root)?; let Some(envelope) = chain.store.get_payload_envelope(&root)? else {
let state_root = if let Some(envelope) = envelope {
envelope.message.state_root
} else {
// The envelope may not be stored yet for the genesis/anchor
// block. Fall back to the block's state_root which is the
// post-payload state for the anchor per get_forkchoice_store.
if parent_block.slot() == chain.spec.genesis_slot {
parent_block.state_root()
} else {
return Err(BeaconChainError::DBInconsistent(format!( return Err(BeaconChainError::DBInconsistent(format!(
"Missing envelope for parent block {root:?}", "Missing envelope for parent block {root:?}",
)) ))
.into()); .into());
}
}; };
let state_root = envelope.message.state_root;
(StatePayloadStatus::Full, state_root) (StatePayloadStatus::Full, state_root)
} else { } else {
(StatePayloadStatus::Pending, parent_block.state_root()) // Post-Gloas empty block case (also covers the Gloas fork transition).
}
} else {
(StatePayloadStatus::Pending, parent_block.state_root()) (StatePayloadStatus::Pending, parent_block.state_root())
}; };
let (parent_state_root, state) = chain let (parent_state_root, state) = chain