gnosis/lighthouse
1
0
Fork 0
mirror of https://github.com/sigp/lighthouse.git synced 2026-03-06 10:11:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update SAMPLES_PER_SLOT to be number of custody groups instead of data columns (#7683)

Browse Source 
Update `SAMPLES_PER_SLOT` to be number of custody groups instead of data columns. This should have no impact on the current implementation as config currently maintains a `group:subnet:column` ratio of `1:1:1`.  **In short, this PR doesn't change anything for Fusaka, but ensures compliance with the spec and potential future changes.**

I've added separate methods to compute sampling columns and custody groups for clarity: `spec.sampling_size_columns` and `spec.sampling_size_custod_groups`

See the clarifications in this PR for more details: https://github.com/ethereum/consensus-specs/pull/4251
This commit is contained in:
Jimmy Chen
2025-07-02 10:08:40 +10:00
committed by GitHub
parent e305cb1b92
commit 41742ce2bd
5 changed files with 71 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
consensus/types/src/chain_spec.rs
View File

@@ -720,17 +720,24 @@ impl ChainSpec {
}
/// Returns the number of column sidecars to sample per slot.
pub fn sampling_size(&self, custody_group_count: u64) -> Result<u64, String> {
pub fn sampling_size_columns(&self, custody_group_count: u64) -> Result<u64, String> {
let sampling_size_groups = self.sampling_size_custody_groups(custody_group_count)?;
let columns_per_custody_group = self
.number_of_columns
.safe_div(self.number_of_custody_groups)
.map_err(|_| "number_of_custody_groups must be greater than 0")?;
let custody_column_count = columns_per_custody_group
.safe_mul(custody_group_count)
let sampling_size_columns = columns_per_custody_group
.safe_mul(sampling_size_groups)
.map_err(|_| "Computing sampling size should not overflow")?;
Ok(std::cmp::max(custody_column_count, self.samples_per_slot))
Ok(sampling_size_columns)
}
/// Returns the number of custody groups to sample per slot.
pub fn sampling_size_custody_groups(&self, custody_group_count: u64) -> Result<u64, String> {
Ok(std::cmp::max(custody_group_count, self.samples_per_slot))
}
pub fn all_data_column_sidecar_subnets(&self) -> impl Iterator<Item = DataColumnSubnetId> {