gnosis/lighthouse
1
0
Fork 0
mirror of https://github.com/sigp/lighthouse.git synced 2026-03-10 04:01:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Ensure non-zero bits for each committee bitfield comprising an aggregate (#6603)

Browse Source 
* add new validation
This commit is contained in:
Eitan Seri-Levi
2024-12-19 14:09:44 +07:00
committed by GitHub
parent 5022398715
commit 42c64a2744
2 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
consensus/state_processing/src/common/get_attesting_indices.rs
View File

@@ -103,14 +103,14 @@ pub mod attesting_indices_electra {
let committee_count_per_slot = committees.len() as u64;
let mut participant_count = 0;
for index in committee_indices {
for committee_index in committee_indices {
let beacon_committee = committees
.get(index as usize)
.ok_or(Error::NoCommitteeFound(index))?;
.get(committee_index as usize)
.ok_or(Error::NoCommitteeFound(committee_index))?;
// This check is new to the spec's `process_attestation` in Electra.
if index >= committee_count_per_slot {
return Err(BeaconStateError::InvalidCommitteeIndex(index));
if committee_index >= committee_count_per_slot {
return Err(BeaconStateError::InvalidCommitteeIndex(committee_index));
}
participant_count.safe_add_assign(beacon_committee.committee.len() as u64)?;
let committee_attesters = beacon_committee
@@ -127,6 +127,12 @@ pub mod attesting_indices_electra {
})
.collect::<HashSet<u64>>();
// Require at least a single non-zero bit for each attesting committee bitfield.
// This check is new to the spec's `process_attestation` in Electra.
if committee_attesters.is_empty() {
return Err(BeaconStateError::EmptyCommittee);
}
attesting_indices.extend(committee_attesters);
committee_offset.safe_add_assign(beacon_committee.committee.len())?;
}