gnosis/lighthouse
1
0
Fork 0
mirror of https://github.com/sigp/lighthouse.git synced 2026-03-03 00:31:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add heaptrack support (#7764)

Browse Source 
Although we're working on jemalloc profiler support in https://github.com/sigp/lighthouse/pull/7746, heaptrack seems to be producing more sensible results.

This PR adds a heaptrack profile and a heaptrack feature so that we no longer need to patch the code in order to use heaptrack. This may prove complementary to jemalloc profiling, so I think there is no harm in having both.
This commit is contained in:
Michael Sproul
2025-07-21 12:11:27 +10:00
committed by GitHub
parent 1046dfbfe7
commit 4a3e248b7e
3 changed files with 13 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
Cargo.toml
View File

@@ -289,5 +289,9 @@ panic = "abort"
codegen-units = 1 codegen-units = 1
overflow-checks = true overflow-checks = true
[profile.release-debug]
inherits = "release"
debug = true
[patch.crates-io] [patch.crates-io]
quick-protobuf = { git = "https://github.com/sigp/quick-protobuf.git", rev = "681f413312404ab6e51f0b46f39b0075c6f4ebfd" } quick-protobuf = { git = "https://github.com/sigp/quick-protobuf.git", rev = "681f413312404ab6e51f0b46f39b0075c6f4ebfd" }

12
lighthouse/Cargo.toml
View File

@@ -35,8 +35,10 @@ beacon-node-leveldb = ["store/leveldb"]
beacon-node-redb = ["store/redb"] beacon-node-redb = ["store/redb"]
# Supports console subscriber for debugging # Supports console subscriber for debugging
console-subscriber = ["console-subscriber/default"] console-subscriber = ["console-subscriber/default"]
# Turns off jemalloc so that heaptrack may be used to analyse memory usage.
heaptrack = []
# Deprecated. This is now enabled by default on non windows targets. # Deprecated. This is now enabled by default on non windows targets (unless heaptrack is enabled).
jemalloc = [] jemalloc = []
[dependencies] [dependencies]
@@ -71,12 +73,12 @@ unused_port = { workspace = true }
validator_client = { workspace = true } validator_client = { workspace = true }
validator_manager = { path = "../validator_manager" } validator_manager = { path = "../validator_manager" }
[target.'cfg(not(target_os = "windows"))'.dependencies] [target.'cfg(any(target_os = "windows", features = "heaptrack"))'.dependencies]
malloc_utils = { workspace = true, features = ["jemalloc"] }
[target.'cfg(target_os = "windows")'.dependencies]
malloc_utils = { workspace = true } malloc_utils = { workspace = true }
[target.'cfg(not(any(target_os = "windows", features = "heaptrack")))'.dependencies]
malloc_utils = { workspace = true, features = ["jemalloc"] }
[dev-dependencies] [dev-dependencies]
beacon_node_fallback = { workspace = true } beacon_node_fallback = { workspace = true }
beacon_processor = { workspace = true } beacon_processor = { workspace = true }

4
lighthouse/src/main.rs
View File

@@ -74,11 +74,11 @@ fn bls_hardware_acceleration() -> bool {
} }
fn allocator_name() -> String { fn allocator_name() -> String {
#[cfg(target_os = "windows")] #[cfg(any(feature = "heaptrack", target_os = "windows"))]
{ {
"system".to_string() "system".to_string()
} }
#[cfg(not(target_os = "windows"))] #[cfg(not(any(feature = "heaptrack", target_os = "windows")))]
match malloc_utils::jemalloc::page_size() { match malloc_utils::jemalloc::page_size() {
Ok(page_size) => format!("jemalloc ({}K)", page_size / 1024), Ok(page_size) => format!("jemalloc ({}K)", page_size / 1024),
Err(e) => format!("jemalloc (error: {e:?})"), Err(e) => format!("jemalloc (error: {e:?})"),