Remove more mentions of "pending"/"full" states (#9156)

Just a little naming cleanup (no semantic changes) to remove mentions of pending and full states that were still lurking.

This hopefully helps Claude forget about the concept (it defaults to naming variables `pending_state`s without this change).


  


Co-Authored-By: Michael Sproul <michael@sigmaprime.io>
This commit is contained in:
Michael Sproul
2026-04-22 12:03:13 +10:00
committed by GitHub
parent 7731b5f250
commit 4de08f1b4a
4 changed files with 27 additions and 36 deletions

View File

@@ -444,9 +444,9 @@ impl<T: BeaconChainTypes> BeaconChain<T> {
/// Complete a block by computing its state root, and
///
/// Return `(block, pending_state, block_value)` where:
/// Return `(block, post_block_state, block_value)` where:
///
/// - `pending_state` is the state post block application (prior to payload application)
/// - `post_block_state` is the state post block application
/// - `block_value` is the consensus-layer rewards for `block`
#[allow(clippy::type_complexity)]
#[instrument(skip_all, level = "debug")]
@@ -571,9 +571,6 @@ impl<T: BeaconChainTypes> BeaconChain<T> {
drop(state_root_timer);
// Clone the Pending state (post-block, pre-envelope) for callers that need it.
let pending_state = state.clone();
let (mut block, _) = signed_beacon_block.deconstruct();
*block.state_root_mut() = state_root;
@@ -628,7 +625,7 @@ impl<T: BeaconChainTypes> BeaconChain<T> {
"Produced beacon block"
);
Ok((block, pending_state, consensus_block_value))
Ok((block, state, consensus_block_value))
}
// TODO(gloas) introduce `ProposerPreferences` so we can build out trustless