mirror of
https://github.com/sigp/lighthouse.git
synced 2026-04-16 12:28:24 +00:00
Rename --subscribe-all-data-column-subnets to --supernode and make it visible in help (#8083)
Rename `--subscribe-all-data-column-subnets` to `--supernode` as it's now been officially accepted in the spec. Also make it visible in help in preparation for the fusaka release. https://github.com/ethereum/consensus-specs/blob/dev/specs/fulu/p2p-interface.md#supernodes Co-Authored-By: Jimmy Chen <jchen.tc@gmail.com>
This commit is contained in:
@@ -47,16 +47,17 @@ pub fn cli_app() -> Command {
|
|||||||
* Network parameters.
|
* Network parameters.
|
||||||
*/
|
*/
|
||||||
.arg(
|
.arg(
|
||||||
Arg::new("subscribe-all-data-column-subnets")
|
Arg::new("supernode")
|
||||||
.long("subscribe-all-data-column-subnets")
|
.long("supernode")
|
||||||
|
.alias("subscribe-all-data-column-subnets")
|
||||||
.action(ArgAction::SetTrue)
|
.action(ArgAction::SetTrue)
|
||||||
.help_heading(FLAG_HEADER)
|
.help_heading(FLAG_HEADER)
|
||||||
.help("Subscribe to all data column subnets and participate in data custody for \
|
.help("Run as a voluntary supernode. This node will subscribe to all data column \
|
||||||
all columns. This will also advertise the beacon node as being long-lived \
|
subnets, custody all data columns, and perform reconstruction and cross-seeding. \
|
||||||
subscribed to all data column subnets. \
|
This requires significantly more bandwidth, storage, and computation requirements but \
|
||||||
NOTE: this is an experimental flag and may change any time without notice!")
|
the node will have direct access to all blobs via the beacon API and it \
|
||||||
|
helps network resilience by serving all data columns to syncing peers.")
|
||||||
.display_order(0)
|
.display_order(0)
|
||||||
.hide(true)
|
|
||||||
)
|
)
|
||||||
.arg(
|
.arg(
|
||||||
// TODO(das): remove this before PeerDAS release
|
// TODO(das): remove this before PeerDAS release
|
||||||
|
|||||||
@@ -1162,7 +1162,7 @@ pub fn set_network_config(
|
|||||||
config.network_dir = data_dir.join(DEFAULT_NETWORK_DIR);
|
config.network_dir = data_dir.join(DEFAULT_NETWORK_DIR);
|
||||||
};
|
};
|
||||||
|
|
||||||
if parse_flag(cli_args, "subscribe-all-data-column-subnets") {
|
if parse_flag(cli_args, "supernode") {
|
||||||
config.subscribe_all_data_column_subnets = true;
|
config.subscribe_all_data_column_subnets = true;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -571,6 +571,13 @@ Flags:
|
|||||||
Subscribe to all subnets regardless of validator count. This will also
|
Subscribe to all subnets regardless of validator count. This will also
|
||||||
advertise the beacon node as being long-lived subscribed to all
|
advertise the beacon node as being long-lived subscribed to all
|
||||||
subnets.
|
subnets.
|
||||||
|
--supernode
|
||||||
|
Run as a voluntary supernode. This node will subscribe to all data
|
||||||
|
column subnets, custody all data columns, and perform reconstruction
|
||||||
|
and cross-seeding. This requires significantly more bandwidth,
|
||||||
|
storage, and computation requirements but the node will have direct
|
||||||
|
access to all blobs via the beacon API and it helps network resilience
|
||||||
|
by serving all data columns to syncing peers.
|
||||||
--validator-monitor-auto
|
--validator-monitor-auto
|
||||||
Enables the automatic detection and monitoring of validators connected
|
Enables the automatic detection and monitoring of validators connected
|
||||||
to the HTTP API and using the subnet subscription endpoint. This
|
to the HTTP API and using the subnet subscription endpoint. This
|
||||||
|
|||||||
@@ -833,6 +833,19 @@ fn network_subscribe_all_data_column_subnets_flag() {
|
|||||||
.with_config(|config| assert!(config.network.subscribe_all_data_column_subnets));
|
.with_config(|config| assert!(config.network.subscribe_all_data_column_subnets));
|
||||||
}
|
}
|
||||||
#[test]
|
#[test]
|
||||||
|
fn network_supernode_flag() {
|
||||||
|
CommandLineTest::new()
|
||||||
|
.flag("supernode", None)
|
||||||
|
.run_with_zero_port()
|
||||||
|
.with_config(|config| assert!(config.network.subscribe_all_data_column_subnets));
|
||||||
|
}
|
||||||
|
#[test]
|
||||||
|
fn network_subscribe_all_data_column_subnets_default() {
|
||||||
|
CommandLineTest::new()
|
||||||
|
.run_with_zero_port()
|
||||||
|
.with_config(|config| assert!(!config.network.subscribe_all_data_column_subnets));
|
||||||
|
}
|
||||||
|
#[test]
|
||||||
fn blob_publication_batches() {
|
fn blob_publication_batches() {
|
||||||
CommandLineTest::new()
|
CommandLineTest::new()
|
||||||
.flag("blob-publication-batches", Some("3"))
|
.flag("blob-publication-batches", Some("3"))
|
||||||
|
|||||||
Reference in New Issue
Block a user