gnosis/lighthouse
1
0
Fork 0
mirror of https://github.com/sigp/lighthouse.git synced 2026-04-21 14:58:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove TestRandom impl for IndexedAttestation

Browse Source
This commit is contained in:
dapplion
2024-06-17 18:34:54 +02:00
parent 5acc0523df
commit 4f08f6e0da
1 changed files with 10 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
consensus/types/src/indexed_attestation.rs
View File

@@ -1,7 +1,6 @@
use crate::{test_utils::TestRandom, AggregateSignature, AttestationData, EthSpec, VariableList}; use crate::{test_utils::TestRandom, AggregateSignature, AttestationData, EthSpec, VariableList};
use core::slice::Iter; use core::slice::Iter;
use derivative::Derivative; use derivative::Derivative;
use rand::RngCore;
use serde::{Deserialize, Serialize}; use serde::{Deserialize, Serialize};
use ssz::Decode; use ssz::Decode;
use ssz::Encode; use ssz::Encode;
@@ -208,23 +207,6 @@ impl<E: EthSpec> Decode for IndexedAttestation<E> {
} }
} }
// TODO(electra): think about how to handle fork variants here
impl<E: EthSpec> TestRandom for IndexedAttestation<E> {
fn random_for_test(rng: &mut impl RngCore) -> Self {
let attesting_indices = VariableList::random_for_test(rng);
// let committee_bits: BitList<E::MaxCommitteesPerSlot> = BitList::random_for_test(rng);
let data = AttestationData::random_for_test(rng);
let signature = AggregateSignature::random_for_test(rng);
Self::Base(IndexedAttestationBase {
attesting_indices,
// committee_bits,
data,
signature,
})
}
}
/// Implementation of non-crypto-secure `Hash`, for use with `HashMap` and `HashSet`. /// Implementation of non-crypto-secure `Hash`, for use with `HashMap` and `HashSet`.
/// ///
/// Guarantees `att1 == att2 -> hash(att1) == hash(att2)`. /// Guarantees `att1 == att2 -> hash(att1) == hash(att2)`.
@@ -333,14 +315,22 @@ mod tests {
assert!(!indexed_vote_first.is_surround_vote(&indexed_vote_second)); assert!(!indexed_vote_first.is_surround_vote(&indexed_vote_second));
} }
ssz_and_tree_hash_tests!(IndexedAttestation<MainnetEthSpec>); mod base {
use super::*;
ssz_and_tree_hash_tests!(IndexedAttestationBase<MainnetEthSpec>);
}
mod electra {
use super::*;
ssz_and_tree_hash_tests!(IndexedAttestationElectra<MainnetEthSpec>);
}
fn create_indexed_attestation( fn create_indexed_attestation(
target_epoch: u64, target_epoch: u64,
source_epoch: u64, source_epoch: u64,
) -> IndexedAttestation<MainnetEthSpec> { ) -> IndexedAttestation<MainnetEthSpec> {
let mut rng = XorShiftRng::from_seed([42; 16]); let mut rng = XorShiftRng::from_seed([42; 16]);
let mut indexed_vote = IndexedAttestation::random_for_test(&mut rng); let mut indexed_vote =
IndexedAttestation::Base(IndexedAttestationBase::random_for_test(&mut rng));
indexed_vote.data_mut().source.epoch = Epoch::new(source_epoch); indexed_vote.data_mut().source.epoch = Epoch::new(source_epoch);
indexed_vote.data_mut().target.epoch = Epoch::new(target_epoch); indexed_vote.data_mut().target.epoch = Epoch::new(target_epoch);