Remove instrumenting log level (#7636)

https://github.com/sigp/lighthouse/issues/7155


  Theres some additional places we set instrumenting log levels that wasn't covered in #7620
This commit is contained in:
Eitan Seri-Levi
2025-06-24 09:29:10 +03:00
committed by GitHub
parent fd643c310c
commit 56b2d4b525
8 changed files with 33 additions and 144 deletions

View File

@@ -127,7 +127,7 @@ use lighthouse_network::service::api_types::Id;
pub(crate) type BlockLookupSummary = (Id, Hash256, Option<Hash256>, Vec<PeerId>);
impl<T: BeaconChainTypes> BlockLookups<T> {
#[instrument(parent = None,level = "info", fields(service = "lookup_sync"), name = "lookup_sync")]
#[instrument(parent = None, fields(service = "lookup_sync"), name = "lookup_sync")]
pub fn new() -> Self {
Self {
failed_chains: LRUTimeCache::new(Duration::from_secs(
@@ -149,7 +149,6 @@ impl<T: BeaconChainTypes> BlockLookups<T> {
#[cfg(test)]
#[instrument(parent = None,
level = "info",
fields(service = "lookup_sync"),
name = "lookup_sync",
skip_all
@@ -160,7 +159,6 @@ impl<T: BeaconChainTypes> BlockLookups<T> {
#[cfg(test)]
#[instrument(parent = None,
level = "info",
fields(service = "lookup_sync"),
name = "lookup_sync",
skip_all
@@ -174,7 +172,6 @@ impl<T: BeaconChainTypes> BlockLookups<T> {
/// Returns a vec of all parent lookup chains by tip, in descending slot order (tip first)
#[instrument(parent = None,
level = "info",
fields(service = "lookup_sync"),
name = "lookup_sync",
skip_all
@@ -196,7 +193,6 @@ impl<T: BeaconChainTypes> BlockLookups<T> {
///
/// Returns true if the lookup is created or already exists
#[instrument(parent = None,
level = "info",
fields(service = "lookup_sync"),
name = "lookup_sync",
skip_all
@@ -235,7 +231,6 @@ impl<T: BeaconChainTypes> BlockLookups<T> {
///
/// Returns true if the lookup is created or already exists
#[instrument(parent = None,
level = "info",
fields(service = "lookup_sync"),
name = "lookup_sync",
skip_all
@@ -257,7 +252,6 @@ impl<T: BeaconChainTypes> BlockLookups<T> {
///
/// Returns true if the lookup is created or already exists
#[instrument(parent = None,
level = "info",
fields(service = "lookup_sync"),
name = "lookup_sync",
skip_all
@@ -365,7 +359,6 @@ impl<T: BeaconChainTypes> BlockLookups<T> {
/// constructed.
/// Returns true if the lookup is created or already exists
#[instrument(parent = None,
level = "info",
fields(service = "lookup_sync"),
name = "lookup_sync",
skip_all
@@ -474,7 +467,6 @@ impl<T: BeaconChainTypes> BlockLookups<T> {
/// Process a block or blob response received from a single lookup request.
#[instrument(parent = None,
level = "info",
fields(service = "lookup_sync"),
name = "lookup_sync",
skip_all
@@ -565,7 +557,6 @@ impl<T: BeaconChainTypes> BlockLookups<T> {
/* Error responses */
#[instrument(parent = None,
level = "info",
fields(service = "lookup_sync"),
name = "lookup_sync",
skip_all
@@ -579,7 +570,6 @@ impl<T: BeaconChainTypes> BlockLookups<T> {
/* Processing responses */
#[instrument(parent = None,
level = "info",
fields(service = "lookup_sync"),
name = "lookup_sync",
skip_all
@@ -605,7 +595,6 @@ impl<T: BeaconChainTypes> BlockLookups<T> {
}
#[instrument(parent = None,
level = "info",
fields(service = "lookup_sync"),
name = "lookup_sync",
skip_all
@@ -800,7 +789,6 @@ impl<T: BeaconChainTypes> BlockLookups<T> {
}
#[instrument(parent = None,
level = "info",
fields(service = "lookup_sync"),
name = "lookup_sync",
skip_all
@@ -831,7 +819,6 @@ impl<T: BeaconChainTypes> BlockLookups<T> {
/// Makes progress on the immediate children of `block_root`
#[instrument(parent = None,
level = "info",
fields(service = "lookup_sync"),
name = "lookup_sync",
skip_all
@@ -862,7 +849,6 @@ impl<T: BeaconChainTypes> BlockLookups<T> {
/// the parent to make progress to resolve, therefore we must drop them if the parent is
/// dropped.
#[instrument(parent = None,
level = "info",
fields(service = "lookup_sync"),
name = "lookup_sync",
skip_all
@@ -892,7 +878,6 @@ impl<T: BeaconChainTypes> BlockLookups<T> {
/// Common handler a lookup request error, drop it and update metrics
/// Returns true if the lookup is created or already exists
#[instrument(parent = None,
level = "info",
fields(service = "lookup_sync"),
name = "lookup_sync",
skip_all
@@ -935,7 +920,6 @@ impl<T: BeaconChainTypes> BlockLookups<T> {
/// Drops all the single block requests and returns how many requests were dropped.
#[instrument(parent = None,
level = "info",
fields(service = "lookup_sync"),
name = "lookup_sync",
skip_all
@@ -947,7 +931,6 @@ impl<T: BeaconChainTypes> BlockLookups<T> {
}
#[instrument(parent = None,
level = "info",
fields(service = "lookup_sync"),
name = "lookup_sync",
skip_all
@@ -961,7 +944,6 @@ impl<T: BeaconChainTypes> BlockLookups<T> {
/// Perform some prune operations on lookups on some interval
#[instrument(parent = None,
level = "info",
fields(service = "lookup_sync"),
name = "lookup_sync",
skip_all
@@ -990,7 +972,6 @@ impl<T: BeaconChainTypes> BlockLookups<T> {
/// Instead there's no negative for keeping lookups with no peers around for some time. If we
/// regularly prune them, it should not be a memory concern (TODO: maybe yes!).
#[instrument(parent = None,
level = "info",
fields(service = "lookup_sync"),
name = "lookup_sync",
skip_all
@@ -1033,7 +1014,6 @@ impl<T: BeaconChainTypes> BlockLookups<T> {
/// - One single clear warn level log per stuck incident
/// - If the original bug is sporadic, it reduces the time a node is stuck from forever to 15 min
#[instrument(parent = None,
level = "info",
fields(service = "lookup_sync"),
name = "lookup_sync",
skip_all
@@ -1076,7 +1056,6 @@ impl<T: BeaconChainTypes> BlockLookups<T> {
/// Recursively find the oldest ancestor lookup of another lookup
#[instrument(parent = None,
level = "info",
fields(service = "lookup_sync"),
name = "lookup_sync",
skip_all
@@ -1106,7 +1085,6 @@ impl<T: BeaconChainTypes> BlockLookups<T> {
/// Note: Takes a `lookup_id` as argument to allow recursion on mutable lookups, without having
/// to duplicate the code to add peers to a lookup
#[instrument(parent = None,
level = "info",
fields(service = "lookup_sync"),
name = "lookup_sync",
skip_all