Ensure attestations are created with empty signature (#960)

* Ensure attestations are created with empty sig

* Update docs

beacon_node/beacon_chain/src/beacon_chain.rs

@@ -756,7 +756,7 @@ impl<T: BeaconChainTypes> BeaconChain<T> {
                     root: target_root,
                 },
             },
-            signature: AggregateSignature::new(),
+            signature: AggregateSignature::empty_signature(),
         })
     }
 

beacon_node/beacon_chain/tests/attestation_production.rs

@@ -106,7 +106,7 @@ fn produces_attestations() {
             );
             assert_eq!(
                 attestation.signature,
-                AggregateSignature::new(),
+                AggregateSignature::empty_signature(),
                 "bad signature"
             );
             assert_eq!(data.index, index, "bad index");