gnosis/lighthouse
1
0
Fork 0
mirror of https://github.com/sigp/lighthouse.git synced 2026-06-29 10:54:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add comments for potential versioning confusion

Browse Source
This commit is contained in:
Pawan Dhananjay
2024-05-08 16:46:23 -07:00
parent dd5c9a8c81
commit 5e1d5ff641
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
beacon_node/execution_layer/src/test_utils/handle_rpc.rs
View File

@@ -111,6 +111,9 @@ pub async fn handle_rpc<E: EthSpec>(
.map(|jep| JsonExecutionPayload::V1(jep)) .map(|jep| JsonExecutionPayload::V1(jep))
}) })
.map_err(|s| (s, BAD_PARAMS_ERROR_CODE))?, .map_err(|s| (s, BAD_PARAMS_ERROR_CODE))?,
// From v3 onwards, we use the newPayload version only for the corresponding
// ExecutionPayload version. So we return an error instead of falling back to
// older versions of newPayload
ENGINE_NEW_PAYLOAD_V3 => get_param::<JsonExecutionPayloadV3<E>>(params, 0) ENGINE_NEW_PAYLOAD_V3 => get_param::<JsonExecutionPayloadV3<E>>(params, 0)
.map(|jep| JsonExecutionPayload::V3(jep)) .map(|jep| JsonExecutionPayload::V3(jep))
.map_err(|s| (s, BAD_PARAMS_ERROR_CODE))?, .map_err(|s| (s, BAD_PARAMS_ERROR_CODE))?,
@@ -337,6 +340,9 @@ pub async fn handle_rpc<E: EthSpec>(
} }
_ => unreachable!(), _ => unreachable!(),
}), }),
// From v3 onwards, we use the getPayload version only for the corresponding
// ExecutionPayload version. So we return an error if the ExecutionPayload version
// we get does not correspond to the getPayload version.
ENGINE_GET_PAYLOAD_V3 => Ok(match JsonExecutionPayload::from(response) { ENGINE_GET_PAYLOAD_V3 => Ok(match JsonExecutionPayload::from(response) {
JsonExecutionPayload::V3(execution_payload) => { JsonExecutionPayload::V3(execution_payload) => {
serde_json::to_value(JsonGetPayloadResponseV3 { serde_json::to_value(JsonGetPayloadResponseV3 {