mirror of
https://github.com/sigp/lighthouse.git
synced 2026-03-05 09:41:42 +00:00
Fix some todos
This commit is contained in:
@@ -1249,10 +1249,7 @@ impl<T: BeaconChainTypes> BeaconChain<T> {
|
||||
pub fn get_blobs(&self, block_root: &Hash256) -> Result<BlobSidecarList<T::EthSpec>, Error> {
|
||||
match self.store.get_blobs(block_root)? {
|
||||
Some(blobs) => Ok(blobs),
|
||||
None => Ok(BlobSidecarList::empty(
|
||||
// TODO(pawan): fix this
|
||||
self.spec.max_blobs_per_block(Epoch::new(0)) as usize,
|
||||
)),
|
||||
None => Ok(BlobSidecarList::empty_uninitialized()),
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
@@ -1239,8 +1239,6 @@ fn to_fixed_blob_sidecar_list<E: EthSpec>(
|
||||
blobs: Vec<Arc<BlobSidecar<E>>>,
|
||||
max_len: usize,
|
||||
) -> Result<FixedBlobSidecarList<E>, LookupVerifyError> {
|
||||
// TODO(pawan): have a method on fixed runtime vector that just initializes a raw vec with max_len = None
|
||||
// to signify an empty fixed runtime vector
|
||||
let mut fixed_list = FixedBlobSidecarList::new(vec![None; max_len]);
|
||||
for blob in blobs.into_iter() {
|
||||
let index = blob.index as usize;
|
||||
|
||||
@@ -1176,7 +1176,6 @@ impl ChainSpec {
|
||||
max_request_data_column_sidecars: default_max_request_data_column_sidecars(),
|
||||
min_epochs_for_blob_sidecars_requests: 16384,
|
||||
blob_sidecar_subnet_count: default_blob_sidecar_subnet_count(),
|
||||
// TODO(pawan): check if gnosis preset values match
|
||||
max_blobs_per_block: default_max_blobs_per_block(),
|
||||
|
||||
/*
|
||||
|
||||
Reference in New Issue
Block a user