gnosis/lighthouse
1
0
Fork 0
mirror of https://github.com/sigp/lighthouse.git synced 2026-05-30 12:47:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix builder exit signature batch verification logic and small refactor (#9173)

Browse Source 
We had a bug when performing batch builder exit signature verification. The EF spec tests cover this case, but the EF tests only calls  individual signature verification (which is a separate code path). This PR unifies the two code paths. We should probably spend some time reviewing EF test code coverage and make sure we don't have separate code paths that do similar things.


  


Co-Authored-By: Eitan Seri-Levi <eserilev@ucsc.edu>
This commit is contained in:
Eitan Seri-Levi
2026-04-26 01:51:02 +02:00
committed by GitHub
parent df764ffa9a
commit 6323cd3827
2 changed files with 27 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
consensus/state_processing/src/per_block_processing/signature_sets.rs
View File

@@ -2,6 +2,7 @@
//! validated individually, or alongside in others in a potentially cheaper bulk operation.
//!
//! This module exposes one function to extract each type of `SignatureSet` from a `BeaconBlock`.
use super::builder::{convert_validator_index_to_builder_index, is_builder_index};
use bls::{AggregateSignature, PublicKey, PublicKeyBytes, Signature, SignatureSet};
use ssz::DecodeError;
use std::borrow::Cow;
@@ -503,7 +504,7 @@ pub fn deposit_pubkey_signature_message(
}
/// Returns a signature set that is valid if the `SignedVoluntaryExit` was signed by the indicated
/// validator.
/// validator (or builder, in the case of a builder exit).
pub fn exit_signature_set<'a, E, F>(
state: &'a BeaconState<E>,
get_pubkey: F,
@@ -515,7 +516,18 @@ where
F: Fn(usize) -> Option<Cow<'a, PublicKey>>,
{
let exit = &signed_exit.message;
let proposer_index = exit.validator_index as usize;
let validator_index = exit.validator_index;
let is_builder_exit =
state.fork_name_unchecked().gloas_enabled() && is_builder_index(validator_index);
let pubkey = if is_builder_exit {
let builder_index = convert_validator_index_to_builder_index(validator_index);
get_builder_pubkey_from_state(state, builder_index)
.ok_or(Error::ValidatorUnknown(validator_index))?
} else {
get_pubkey(validator_index as usize).ok_or(Error::ValidatorUnknown(validator_index))?
};
let domain = if state.fork_name_unchecked().deneb_enabled() {
// EIP-7044
@@ -537,7 +549,7 @@ where
Ok(SignatureSet::single_pubkey(
&signed_exit.signature,
get_pubkey(proposer_index).ok_or(Error::ValidatorUnknown(proposer_index as u64))?,
pubkey,
message,
))
}