Strip off newline chars from password (#1199)

* strips off newline chars from password

* adds changes suggested in author review
This commit is contained in:
Rohit Narurkar
2020-05-28 06:54:49 +05:30
committed by GitHub
parent ea4a52984c
commit 6383c95f8b
2 changed files with 62 additions and 2 deletions

View File

@@ -1,4 +1,7 @@
use crate::{common::random_password, BASE_DIR_FLAG};
use crate::{
common::{random_password, strip_off_newlines},
BASE_DIR_FLAG,
};
use clap::{App, Arg, ArgMatches};
use eth2_wallet::{
bip39::{Language, Mnemonic, MnemonicType},
@@ -104,7 +107,10 @@ pub fn cli_run(matches: &ArgMatches, base_dir: PathBuf) -> Result<(), String> {
let wallet_password = fs::read(&wallet_password_path)
.map_err(|e| format!("Unable to read {:?}: {:?}", wallet_password_path, e))
.map(|bytes| PlainText::from(bytes))?;
.map(|bytes| {
let bytes = strip_off_newlines(bytes);
PlainText::from(bytes)
})?;
let wallet = mgr
.create_wallet(name, wallet_type, &mnemonic, wallet_password.as_bytes())