Improve error types for envelopes (#9414)

N/A


  Currently, we have `EnvelopeError` having a `ImportError` wrapping a `BlockError`. I feel this is extremely unintuitive because most of the envelope processing functions can simply return an `EnvelopeError` that makes sense in the function's context. It revealed further ugliness when implementing range sync in #9362

This PR does 2 main things:
1. Removes `ImportError(BlockError)` variant
2. Adds `EnvelopeError(EnvelopeError)` variant to a `BlockError`.

I feel this is more natural as there can be envelope errors when we try importing a Block but envelope errors can be contained to just envelope related errors.

The main blocker to doing this was `PayloadVerificationHandle` returning a `BlockError`. It uses a very small subset of `BlockError` which I extracted to its own error type which can be converted into both a BlockError and EnvelopeError.

This allows us to keep most of the pure envelope processing functions to just return EnvelopeErrors while we convert it to a `BlockError` only in import paths where we need to return a consolidated `BlockError`.


Co-Authored-By: Pawan Dhananjay <pawandhananjay@gmail.com>
This commit is contained in:
Pawan Dhananjay
2026-06-05 19:27:28 +05:30
committed by GitHub
parent 494b00a349
commit 6698872f8a
10 changed files with 151 additions and 70 deletions

View File

@@ -144,7 +144,7 @@ pub async fn publish_execution_payload_envelope<T: BeaconChainTypes>(
PubsubMessage::ExecutionPayload(Box::new(envelope_for_gossip)),
)
.map_err(|_| {
EnvelopeError::BeaconChainError(Arc::new(
EnvelopeError::BeaconChainError(Box::new(
beacon_chain::BeaconChainError::UnableToPublish,
))
})