Single attestation "Full" implementation (#7444)

#6970


  This allows for us to receive `SingleAttestation` over gossip and process it without converting. There is still a conversion to `Attestation` as a final step in the attestation verification process, but by then the `SingleAttestation` is fully verified.

I've also fully removed the `submitPoolAttestationsV1` endpoint as its been deprecated

I've also pre-emptively deprecated supporting `Attestation` in `submitPoolAttestationsV2` endpoint. See here for more info: https://github.com/ethereum/beacon-APIs/pull/531

I tried to the minimize the diff here by only making the "required" changes. There are some unnecessary complexities with the way we manage the different attestation verification wrapper types. We could probably consolidate this to one wrapper type and refactor this even further. We could leave that to a separate PR if we feel like cleaning things up in the future.

Note that I've also updated the test harness to always submit `SingleAttestation` regardless of fork variant. I don't see a problem in that approach and it allows us to delete more code :)

consensus/types/src/attestation.rs

@@ -1,7 +1,13 @@
-use crate::context_deserialize;
+use super::{
+    AggregateSignature, AttestationData, BitList, ChainSpec, Domain, EthSpec, Fork, SecretKey,
+    Signature, SignedRoot,
+};
 use crate::slot_data::SlotData;
+use crate::{context_deserialize, IndexedAttestation};
 use crate::{test_utils::TestRandom, Hash256, Slot};
-use crate::{Checkpoint, ContextDeserialize, ForkName};
+use crate::{
+    Checkpoint, ContextDeserialize, ForkName, IndexedAttestationBase, IndexedAttestationElectra,
+};
 use derivative::Derivative;
 use serde::{Deserialize, Deserializer, Serialize};
 use ssz_derive::{Decode, Encode};
@@ -12,11 +18,6 @@ use superstruct::superstruct;
 use test_random_derive::TestRandom;
 use tree_hash_derive::TreeHash;
 
-use super::{
-    AggregateSignature, AttestationData, BitList, ChainSpec, Domain, EthSpec, Fork, SecretKey,
-    Signature, SignedRoot,
-};
-
 #[derive(Debug, PartialEq, Clone)]
 pub enum Error {
     SszTypesError(ssz_types::Error),
@@ -246,10 +247,17 @@ impl<E: EthSpec> Attestation<E> {
         attester_index: u64,
     ) -> Result<SingleAttestation, Error> {
         match self {
-            Self::Base(_) => Err(Error::IncorrectStateVariant),
+            Self::Base(attn) => attn.to_single_attestation_with_attester_index(attester_index),
             Self::Electra(attn) => attn.to_single_attestation_with_attester_index(attester_index),
         }
     }
+
+    pub fn get_aggregation_bits(&self) -> Vec<u64> {
+        match self {
+            Self::Base(attn) => attn.get_aggregation_bits(),
+            Self::Electra(attn) => attn.get_aggregation_bits(),
+        }
+    }
 }
 
 impl<E: EthSpec> AttestationRef<'_, E> {
@@ -461,6 +469,26 @@ impl<E: EthSpec> AttestationBase<E> {
     ) -> Result<BitList<E::MaxValidatorsPerSlot>, ssz::BitfieldError> {
         self.aggregation_bits.resize::<E::MaxValidatorsPerSlot>()
     }
+
+    pub fn get_aggregation_bits(&self) -> Vec<u64> {
+        self.aggregation_bits
+            .iter()
+            .enumerate()
+            .filter_map(|(index, bit)| if bit { Some(index as u64) } else { None })
+            .collect()
+    }
+
+    pub fn to_single_attestation_with_attester_index(
+        &self,
+        attester_index: u64,
+    ) -> Result<SingleAttestation, Error> {
+        Ok(SingleAttestation {
+            committee_index: self.data.index,
+            attester_index,
+            data: self.data.clone(),
+            signature: self.signature.clone(),
+        })
+    }
 }
 
 impl<E: EthSpec> SlotData for Attestation<E> {
@@ -596,6 +624,24 @@ pub struct SingleAttestation {
     pub signature: AggregateSignature,
 }
 
+impl SingleAttestation {
+    pub fn to_indexed<E: EthSpec>(&self, fork_name: ForkName) -> IndexedAttestation<E> {
+        if fork_name.electra_enabled() {
+            IndexedAttestation::Electra(IndexedAttestationElectra {
+                attesting_indices: vec![self.attester_index].into(),
+                data: self.data.clone(),
+                signature: self.signature.clone(),
+            })
+        } else {
+            IndexedAttestation::Base(IndexedAttestationBase {
+                attesting_indices: vec![self.attester_index].into(),
+                data: self.data.clone(),
+                signature: self.signature.clone(),
+            })
+        }
+    }
+}
+
 #[cfg(test)]
 mod tests {
     use super::*;