Remove deprecated flags in prep for v6.0.0 (#6490)

* Delete previously deprecated flags

* Update CLI docs

* Remove deprecated BN flags

* Use ethereum-package main branch

* Delete env_log/-l

lighthouse/src/main.rs

@@ -115,16 +115,6 @@ fn main() {
                 .global(true)
                 .display_order(0),
         )
-        .arg(
-            Arg::new("env_log")
-                .short('l')
-                .help(
-                    "DEPRECATED Enables environment logging giving access to sub-protocol logs such as discv5 and libp2p",
-                )
-                .action(ArgAction::SetTrue)
-                .help_heading(FLAG_HEADER)
-                .display_order(0)
-        )
         .arg(
             Arg::new("logfile")
                 .long("logfile")

lighthouse/tests/beacon_node.rs

@@ -159,13 +159,6 @@ fn max_skip_slots_flag() {
         .with_config(|config| assert_eq!(config.chain.import_max_skip_slots, Some(10)));
 }
 
-#[test]
-fn disable_lock_timeouts_flag() {
-    CommandLineTest::new()
-        .flag("disable-lock-timeouts", None)
-        .run_with_zero_port();
-}
-
 #[test]
 fn shuffling_cache_default() {
     CommandLineTest::new()
@@ -1612,19 +1605,6 @@ fn http_port_flag() {
         .run()
         .with_config(|config| assert_eq!(config.http_api.listen_port, port1));
 }
-#[test]
-fn empty_self_limiter_flag() {
-    // Test that empty rate limiter is accepted using the default rate limiting configurations.
-    CommandLineTest::new()
-        .flag("self-limiter", None)
-        .run_with_zero_port()
-        .with_config(|config| {
-            assert_eq!(
-                config.network.outbound_rate_limiter_config,
-                Some(lighthouse_network::rpc::config::OutboundRateLimiterConfig::default())
-            )
-        });
-}
 
 #[test]
 fn empty_inbound_rate_limiter_flag() {
@@ -1667,14 +1647,6 @@ fn http_allow_origin_all_flag() {
         .with_config(|config| assert_eq!(config.http_api.allow_origin, Some("*".to_string())));
 }
 
-#[test]
-fn http_allow_sync_stalled_flag() {
-    CommandLineTest::new()
-        .flag("http", None)
-        .flag("http-allow-sync-stalled", None)
-        .run_with_zero_port();
-}
-
 #[test]
 fn http_enable_beacon_processor() {
     CommandLineTest::new()
@@ -1713,22 +1685,6 @@ fn http_tls_flags() {
         });
 }
 
-#[test]
-fn http_spec_fork_default() {
-    CommandLineTest::new()
-        .flag("http", None)
-        .run_with_zero_port()
-        .with_config(|config| assert_eq!(config.http_api.spec_fork_name, None));
-}
-
-#[test]
-fn http_spec_fork_override() {
-    CommandLineTest::new()
-        .flag("http", None)
-        .flag("http-spec-fork", Some("altair"))
-        .run_with_zero_port();
-}
-
 // Tests for Metrics flags.
 #[test]
 fn metrics_flag() {
@@ -2631,14 +2587,6 @@ fn invalid_gossip_verified_blocks_path() {
         });
 }
 
-#[test]
-fn progressive_balances_checked() {
-    // Flag is deprecated but supplying it should not crash until we remove it completely.
-    CommandLineTest::new()
-        .flag("progressive-balances", Some("checked"))
-        .run_with_zero_port();
-}
-
 #[test]
 fn beacon_processor() {
     CommandLineTest::new()

lighthouse/tests/validator_client.rs

@@ -426,13 +426,6 @@ fn no_doppelganger_protection_flag() {
         .with_config(|config| assert!(!config.enable_doppelganger_protection));
 }
 
-#[test]
-fn produce_block_v3_flag() {
-    // The flag is DEPRECATED but providing it should not trigger an error.
-    // We can delete this test when deleting the flag entirely.
-    CommandLineTest::new().flag("produce-block-v3", None).run();
-}
-
 #[test]
 fn no_gas_limit_flag() {
     CommandLineTest::new()
@@ -513,23 +506,6 @@ fn monitoring_endpoint() {
             assert_eq!(api_conf.update_period_secs, Some(30));
         });
 }
-#[test]
-fn disable_run_on_all_flag() {
-    CommandLineTest::new()
-        .flag("disable-run-on-all", None)
-        .run()
-        .with_config(|config| {
-            assert_eq!(config.broadcast_topics, vec![]);
-        });
-    // --broadcast flag takes precedence
-    CommandLineTest::new()
-        .flag("disable-run-on-all", None)
-        .flag("broadcast", Some("attestations"))
-        .run()
-        .with_config(|config| {
-            assert_eq!(config.broadcast_topics, vec![ApiTopic::Attestations]);
-        });
-}
 
 #[test]
 fn no_broadcast_flag() {
@@ -623,16 +599,6 @@ fn disable_latency_measurement_service() {
             assert!(!config.enable_latency_measurement_service);
         });
 }
-#[test]
-fn latency_measurement_service() {
-    // This flag is DEPRECATED so has no effect, but should still be accepted.
-    CommandLineTest::new()
-        .flag("latency-measurement-service", Some("false"))
-        .run()
-        .with_config(|config| {
-            assert!(config.enable_latency_measurement_service);
-        });
-}
 
 #[test]
 fn validator_registration_batch_size() {