gnosis/lighthouse
1
0
Fork 0
mirror of https://github.com/sigp/lighthouse.git synced 2026-07-04 21:34:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

Clarify TODOs in envelope verification

Browse Source
This commit is contained in:
Michael Sproul
2026-01-19 14:46:33 +11:00
parent 9e365e535f
commit 718a420fe8
2 changed files with 11 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
beacon_node/beacon_chain/src/beacon_chain.rs
View File

@@ -1144,7 +1144,6 @@ impl<T: BeaconChainTypes> BeaconChain<T> {
/// Returns the full block at the given root, if it's available in the database. /// Returns the full block at the given root, if it's available in the database.
/// ///
/// Should always return a full block for pre-merge and post-gloas blocks. /// Should always return a full block for pre-merge and post-gloas blocks.
/// An
pub fn get_full_block( pub fn get_full_block(
&self, &self,
block_root: &Hash256, block_root: &Hash256,

19
beacon_node/beacon_chain/src/envelope_verification.rs
View File

@@ -220,8 +220,13 @@ impl<T: BeaconChainTypes> GossipVerifiedEnvelope<T> {
let payload = &envelope.payload; let payload = &envelope.payload;
let beacon_block_root = envelope.beacon_block_root; let beacon_block_root = envelope.beacon_block_root;
// check that we've seen the parent block of this envelope and that it passes validation // Check that we've seen the beacon block for this envelope and that it passes validation.
// TODO(EIP-7732): this check would fail if the block didn't pass validation right? // TODO(EIP-7732): We need a block status table in order to differentiate between:
//
// 1. Blocks we haven't seen (IGNORE), and
// 2. Blocks we've seen that are invalid (REJECT).
//
// Presently these two cases are conflated.
let fork_choice_read_lock = chain.canonical_head.fork_choice_read_lock(); let fork_choice_read_lock = chain.canonical_head.fork_choice_read_lock();
let Some(parent_proto_block) = fork_choice_read_lock.get_block(&beacon_block_root) else { let Some(parent_proto_block) = fork_choice_read_lock.get_block(&beacon_block_root) else {
return Err(EnvelopeError::BlockRootUnknown { return Err(EnvelopeError::BlockRootUnknown {
@@ -233,7 +238,7 @@ impl<T: BeaconChainTypes> GossipVerifiedEnvelope<T> {
// TODO(EIP-7732): check that we haven't seen another valid `SignedExecutionPayloadEnvelope` // TODO(EIP-7732): check that we haven't seen another valid `SignedExecutionPayloadEnvelope`
// for this block root from this builder - envelope status table check // for this block root from this builder - envelope status table check
// TODO(EIP-7732): this should probably be obtained from the ProtoBlock instead of the DB // TODO(EIP-7732): this could be obtained from the ProtoBlock instead of the DB
// but this means the ProtoBlock needs to include something like the ExecutionBid // but this means the ProtoBlock needs to include something like the ExecutionBid
// will need to answer this question later. // will need to answer this question later.
let parent_block = chain let parent_block = chain
@@ -278,11 +283,9 @@ impl<T: BeaconChainTypes> GossipVerifiedEnvelope<T> {
}); });
} }
// TODO(EIP-7732): check these assumptions.. exactly what the most efficient way to verify the signatures // Get the fork from the proposer cache so we can verify the signature.
// in this case isn't clear. There are questions about the proposer cache, the pubkey cache, // This is currently the most efficient way to implement envelope signature verification
// and so on. // because the `fork` might depend on advancing the parent state.
// get the fork from the cache so we can verify the signature
let block_slot = envelope.slot; let block_slot = envelope.slot;
let block_epoch = block_slot.epoch(T::EthSpec::slots_per_epoch()); let block_epoch = block_slot.epoch(T::EthSpec::slots_per_epoch());
let proposer_shuffling_decision_block = let proposer_shuffling_decision_block =