Validator client refactor (#618)

* Update to spec v0.9.0

* Update to v0.9.1

* Bump spec tags for v0.9.1

* Formatting, fix CI failures

* Resolve accidental KeyPair merge conflict

* Document new BeaconState functions

* Add `validator` changes from `validator-to-rest`

* Add initial (failing) REST api tests

* Fix signature parsing

* Add more tests

* Refactor http router

* Add working tests for publish beacon block

* Add validator duties tests

* Move account_manager under `lighthouse` binary

* Unify logfile handling in `environment` crate.

* Fix incorrect cache drops in `advance_caches`

* Update fork choice for v0.9.1

* Add `deposit_contract` crate

* Add progress on validator onboarding

* Add unfinished attesation code

* Update account manager CLI

* Write eth1 data file as hex string

* Integrate ValidatorDirectory with validator_client

* Move ValidatorDirectory into validator_client

* Clean up some FIXMEs

* Add beacon_chain_sim

* Fix a few docs/logs

* Expand `beacon_chain_sim`

* Fix spec for `beacon_chain_sim

* More testing for api

* Start work on attestation endpoint

* Reject empty attestations

* Allow attestations to genesis block

* Add working tests for `rest_api` validator endpoint

* Remove grpc from beacon_node

* Start heavy refactor of validator client

- Block production is working

* Prune old validator client files

* Start works on attestation service

* Add attestation service to validator client

* Use full pubkey for validator directories

* Add validator duties post endpoint

* Use par_iter for keypair generation

* Use bulk duties request in validator client

* Add version http endpoint tests

* Add interop keys and startup wait

* Ensure a prompt exit

* Add duties pruning

* Fix compile error in beacon node tests

* Add github workflow

* Modify rust.yaml

* Modify gitlab actions

* Add to CI file

* Add sudo to CI npm install

* Move cargo fmt to own job in tests

* Fix cargo fmt in CI

* Add rustup update before cargo fmt

* Change name of CI job

* Make other CI jobs require cargo fmt

* Add CI badge

* Remove gitlab and travis files

* Add different http timeout for debug

* Update docker file, use makefile in CI

* Use make in the dockerfile, skip the test

* Use the makefile for debug GI test

* Update book

* Tidy grpc and misc things

* Apply discv5 fixes

* Address other minor issues

* Fix warnings

* Attempt fix for addr parsing

* Tidy validator config, CLIs

* Tidy comments

* Tidy signing, reduce ForkService duplication

* Fail if skipping too many slots

* Set default recent genesis time to 0

* Add custom http timeout to validator

* Fix compile bug in node_test_rig

* Remove old bootstrap flag from val CLI

* Update docs

* Tidy val client

* Change val client log levels

* Add comments, more validity checks

* Fix compile error, add comments

* Undo changes to eth2-libp2p/src

* Reduce duplication of keypair generation

* Add more logging for validator duties

* Fix beacon_chain_sim, nitpicks

* Fix compile error, minor nits

* Address Michael's comments

beacon_node/src/cli.rs

@@ -1,22 +1,14 @@
 use clap::{App, Arg, SubCommand};
 
 pub fn cli_app<'a, 'b>() -> App<'a, 'b> {
-    App::new("Beacon Node")
-        .visible_aliases(&["b", "bn", "beacon", "beacon_node"])
+    App::new("beacon_node")
+        .visible_aliases(&["b", "bn", "beacon"])
         .version(crate_version!())
         .author("Sigma Prime <contact@sigmaprime.io>")
         .about("Eth 2.0 Client")
         /*
          * Configuration directory locations.
          */
-        .arg(
-            Arg::with_name("datadir")
-                .long("datadir")
-                .value_name("DIR")
-                .help("Data directory for keys and databases.")
-                .takes_value(true)
-                .global(true)
-        )
         .arg(
             Arg::with_name("network-dir")
                 .long("network-dir")
@@ -103,30 +95,6 @@ pub fn cli_app<'a, 'b>() -> App<'a, 'b> {
                 .help("A secp256k1 secret key, represented as ASCII-encoded hex bytes (with or without 0x prefix).")
                 .takes_value(true),
         )
-        /*
-         * gRPC parameters.
-         */
-        .arg(
-            Arg::with_name("no-grpc")
-                .long("no-grpc")
-                .help("Disable the gRPC server.")
-                .takes_value(false),
-        )
-        .arg(
-            Arg::with_name("rpc-address")
-                .long("rpc-address")
-                .value_name("ADDRESS")
-                .help("Listen address for RPC endpoint.")
-                .takes_value(true),
-        )
-        .arg(
-            Arg::with_name("rpc-port")
-                .long("rpc-port")
-                .value_name("PORT")
-                .help("Listen port for RPC endpoint.")
-                .conflicts_with("port-bump")
-                .takes_value(true),
-        )
         /* REST API related arguments */
         .arg(
             Arg::with_name("no-api")
@@ -299,7 +267,7 @@ pub fn cli_app<'a, 'b>() -> App<'a, 'b> {
                     .short("m")
                     .value_name("MINUTES")
                     .required(true)
-                    .default_value("15")
+                    .default_value("0")
                     .help("The maximum number of minutes that will have elapsed before genesis"))
             )
             /*