Clippy clean (#536)

* Change into_iter to iter

* Fix clippy 'easy' warnings

* Clippy eth2/utils

* Add struct NetworkInfo

* Clippy for types, utils, and beacon_node/store/src/iters.rs

* Cargo fmt

* Change foo to my_foo

* Remove complex signature

* suppress clippy warning for unit_value in benches

* Use enumerate instead of iterating over range

* Allow trivially_copy_pass_by_ref in serde_utils

beacon_node/client/src/lib.rs

@@ -12,6 +12,7 @@ use beacon_chain::{
 use exit_future::Signal;
 use futures::{future::Future, Stream};
 use network::Service as NetworkService;
+use rest_api::NetworkInfo;
 use slog::{crit, error, info, o};
 use slot_clock::SlotClock;
 use std::marker::PhantomData;
@@ -231,12 +232,15 @@ where
 
         // Start the `rest_api` service
         let api_exit_signal = if client_config.rest_api.enabled {
+            let network_info = NetworkInfo {
+                network_service: network.clone(),
+                network_chan: network_send.clone(),
+            };
             match rest_api::start_server(
                 &client_config.rest_api,
                 executor,
                 beacon_chain.clone(),
-                network.clone(),
-                network_send.clone(),
+                network_info,
                 client_config.db_path().expect("unable to read datadir"),
                 eth2_config.clone(),
                 &log,