From 7fce143300a6310677b974ef729a482a467f8e27 Mon Sep 17 00:00:00 2001
From: dapplion <35266934+dapplion@users.noreply.github.com>
Date: Tue, 18 Jun 2024 22:16:37 +0200
Subject: [PATCH] Resolve into_attestation_and_indices todo

---
 .../src/network_beacon_processor/gossip_methods.rs        | 7 +------
 consensus/types/src/signed_aggregate_and_proof.rs         | 8 ++++++++
 2 files changed, 9 insertions(+), 6 deletions(-)

diff --git a/beacon_node/network/src/network_beacon_processor/gossip_methods.rs b/beacon_node/network/src/network_beacon_processor/gossip_methods.rs
index 34eb8b26b1..8cbc778218 100644
--- a/beacon_node/network/src/network_beacon_processor/gossip_methods.rs
+++ b/beacon_node/network/src/network_beacon_processor/gossip_methods.rs
@@ -105,12 +105,7 @@ impl<T: BeaconChainTypes> VerifiedAttestation<T> for VerifiedAggregate<T> {
 
     /// Efficient clone-free implementation that moves out of the `Box`.
     fn into_attestation_and_indices(self) -> (Attestation<T::EthSpec>, Vec<u64>) {
-        // TODO(electra): technically we shouldn't have to clone..
-        let attestation = self
-            .signed_aggregate
-            .message()
-            .aggregate()
-            .clone_as_attestation();
+        let attestation = self.signed_aggregate.into_attestation();
         let attesting_indices = self.indexed_attestation.attesting_indices_to_vec();
         (attestation, attesting_indices)
     }
diff --git a/consensus/types/src/signed_aggregate_and_proof.rs b/consensus/types/src/signed_aggregate_and_proof.rs
index 94624f02fe..d339cecaae 100644
--- a/consensus/types/src/signed_aggregate_and_proof.rs
+++ b/consensus/types/src/signed_aggregate_and_proof.rs
@@ -6,6 +6,7 @@ use super::{
     Signature, SignedRoot,
 };
 use crate::test_utils::TestRandom;
+use crate::Attestation;
 use serde::{Deserialize, Serialize};
 use ssz_derive::{Decode, Encode};
 use superstruct::superstruct;
@@ -109,4 +110,11 @@ impl<E: EthSpec> SignedAggregateAndProof<E> {
             }
         }
     }
+
+    pub fn into_attestation(self) -> Attestation<E> {
+        match self {
+            Self::Base(att) => Attestation::Base(att.message.aggregate),
+            Self::Electra(att) => Attestation::Electra(att.message.aggregate),
+        }
+    }
 }