From 810156a0fb347ffc54ddbd71b1e970ae772d175f Mon Sep 17 00:00:00 2001 From: Paul Hauner Date: Wed, 26 Dec 2018 08:46:37 +1100 Subject: [PATCH] Remove Default impls for BLS newtypes --- beacon_chain/utils/bls/src/aggregate_signature.rs | 7 ------- beacon_chain/utils/bls/src/signature.rs | 11 ----------- 2 files changed, 18 deletions(-) diff --git a/beacon_chain/utils/bls/src/aggregate_signature.rs b/beacon_chain/utils/bls/src/aggregate_signature.rs index 5cc9c3c215..656b7e4adf 100644 --- a/beacon_chain/utils/bls/src/aggregate_signature.rs +++ b/beacon_chain/utils/bls/src/aggregate_signature.rs @@ -29,13 +29,6 @@ impl AggregateSignature { } } -impl Default for AggregateSignature { - /// A "default" signature is a signature across an empty message by a secret key of 48 zeros. - fn default() -> Self { - AggregateSignature::new() - } -} - impl Encodable for AggregateSignature { fn ssz_append(&self, s: &mut SszStream) { s.append_vec(&self.0.as_bytes()); diff --git a/beacon_chain/utils/bls/src/signature.rs b/beacon_chain/utils/bls/src/signature.rs index bfeaca45e4..ebdb5b8176 100644 --- a/beacon_chain/utils/bls/src/signature.rs +++ b/beacon_chain/utils/bls/src/signature.rs @@ -36,17 +36,6 @@ impl Signature { } } -impl Default for Signature { - /// A "default" signature is a signature across an empty message by a secret key of 48 zeros. - fn default() -> Self { - let sk = match SecretKey::from_bytes(&[0; 48]) { - Ok(key) => key, - _ => unreachable!(), // Key is static, should not fail. - }; - Signature(RawSignature::new(&[], &sk)) - } -} - impl Encodable for Signature { fn ssz_append(&self, s: &mut SszStream) { s.append_vec(&self.0.as_bytes());