From 81a3114cb80a2aafabe6eb4e51fd74a0f7aa30aa Mon Sep 17 00:00:00 2001 From: Eitan Seri-Levi Date: Wed, 22 Apr 2026 09:58:01 +0900 Subject: [PATCH] unblock some tests --- beacon_node/http_api/tests/interactive_tests.rs | 11 +++-------- beacon_node/http_api/tests/status_tests.rs | 5 +---- beacon_node/http_api/tests/tests.rs | 2 -- 3 files changed, 4 insertions(+), 14 deletions(-) diff --git a/beacon_node/http_api/tests/interactive_tests.rs b/beacon_node/http_api/tests/interactive_tests.rs index 5912d6b1b2..184bfffc9a 100644 --- a/beacon_node/http_api/tests/interactive_tests.rs +++ b/beacon_node/http_api/tests/interactive_tests.rs @@ -61,10 +61,7 @@ async fn state_by_root_pruned_from_fork_choice() { type E = MinimalEthSpec; let validator_count = 24; - // TODO(EIP-7732): extend test for Gloas by reverting back to using `ForkName::latest()` - // Issue is that this test does block production via `extend_chain_with_sync` which expects to be able to use `state.latest_execution_payload_header` during block production, but Gloas uses `latest_execution_bid` instead - // This will be resolved in a subsequent block processing PR - let spec = ForkName::Fulu.make_genesis_spec(E::default_spec()); + let spec = ForkName::latest().make_genesis_spec(E::default_spec()); let tester = InteractiveTester::::new_with_initializer_and_mutator( Some(spec.clone()), @@ -403,10 +400,8 @@ pub async fn proposer_boost_re_org_test( ) { assert!(head_slot > 0); - // Test using the latest fork so that we simulate conditions as similar to mainnet as possible. - // TODO(EIP-7732): extend test for Gloas by reverting back to using `ForkName::latest()` - // Issue is that `get_validator_blocks_v3` below expects to be able to use `state.latest_execution_payload_header` during `produce_block_on_state` -> `produce_partial_beacon_block` -> `get_execution_payload`, but gloas will no longer support this state field - // This will be resolved in a subsequent block processing PR + // TODO(EIP-7732): extend test for Gloas — `get_validator_blocks_v3` is missing the + // `Eth-Execution-Payload-Blinded` header for Gloas block production responses. let mut spec = ForkName::Fulu.make_genesis_spec(E::default_spec()); spec.terminal_total_difficulty = Uint256::from(1); diff --git a/beacon_node/http_api/tests/status_tests.rs b/beacon_node/http_api/tests/status_tests.rs index 791e643ec4..f018cb897e 100644 --- a/beacon_node/http_api/tests/status_tests.rs +++ b/beacon_node/http_api/tests/status_tests.rs @@ -12,10 +12,7 @@ type E = MinimalEthSpec; /// Create a new test environment that is post-merge with `chain_depth` blocks. async fn post_merge_tester(chain_depth: u64, validator_count: u64) -> InteractiveTester { - // TODO(EIP-7732): extend tests for Gloas by reverting back to using `ForkName::latest()` - // Issue is that these tests do block production via `extend_chain_with_sync` which expects to be able to use `state.latest_execution_payload_header` during block production, but Gloas uses `latest_execution_bid` instead - // This will be resolved in a subsequent block processing PR - let mut spec = ForkName::Fulu.make_genesis_spec(E::default_spec()); + let mut spec = ForkName::latest().make_genesis_spec(E::default_spec()); spec.terminal_total_difficulty = Uint256::from(1); let tester = InteractiveTester::::new(Some(spec), validator_count as usize).await; diff --git a/beacon_node/http_api/tests/tests.rs b/beacon_node/http_api/tests/tests.rs index 4848c50d1b..72abf82be4 100644 --- a/beacon_node/http_api/tests/tests.rs +++ b/beacon_node/http_api/tests/tests.rs @@ -8105,8 +8105,6 @@ async fn get_validator_attestation_data_with_skip_slots() { .await; } -// TODO(EIP-7732): Remove `#[ignore]` once gloas beacon chain harness is implemented -#[ignore] #[tokio::test(flavor = "multi_thread", worker_threads = 2)] async fn get_validator_payload_attestation_data() { if !fork_name_from_env().is_some_and(|f| f.gloas_enabled()) {