Deprecate gossip blobs (#9126)

#9124

Deprecate unneeded pre-Fulu blob features

- blob gossip
- blob lookup sync
- engine getBlobsV1

Also deprecates some tests and cleans up production code paths

I think this is blocked until gnosis forks to fulu?


  


Co-Authored-By: Eitan Seri-Levi <eserilev@ucsc.edu>

Co-Authored-By: Eitan Seri- Levi <eserilev@gmail.com>

Co-Authored-By: dapplion <35266934+dapplion@users.noreply.github.com>

Co-Authored-By: Pawan Dhananjay <pawandhananjay@gmail.com>

Co-Authored-By: Michael Sproul <michael@sigmaprime.io>

Co-Authored-By: Daniel Knopik <daniel@dknopik.de>

Co-Authored-By: Michael Sproul <michaelsproul@users.noreply.github.com>

beacon_node/http_api/src/block_id.rs

@@ -455,20 +455,18 @@ impl BlockId {
                 warp_utils::reject::custom_not_found(format!("no blobs stored for block {root}"))
             })?;
 
-        let blob_sidecar_list_filtered = match indices {
-            Some(vec) => {
-                let list: Vec<_> = vec
-                    .into_iter()
-                    .flat_map(|index| blob_sidecar_list.get(index as usize).cloned())
-                    .collect();
+        let blob_sidecar_list: Vec<_> = blob_sidecar_list.into_iter().collect();
 
-                BlobSidecarList::new(list, max_blobs_per_block)
-                    .map_err(|e| warp_utils::reject::custom_server_error(format!("{:?}", e)))?
-            }
+        let blob_sidecar_list = match indices {
+            Some(indices) => indices
+                .into_iter()
+                .filter_map(|i| blob_sidecar_list.get(i as usize).cloned())
+                .collect(),
             None => blob_sidecar_list,
         };
 
-        Ok(blob_sidecar_list_filtered)
+        BlobSidecarList::new(blob_sidecar_list, max_blobs_per_block)
+            .map_err(|e| warp_utils::reject::custom_server_error(format!("{:?}", e)))
     }
 
     fn get_blobs_from_data_columns<T: BeaconChainTypes>(