From 876e6899cd10c7a68374c63d0827dedddb5df5bc Mon Sep 17 00:00:00 2001 From: Eitan Seri- Levi Date: Tue, 24 Feb 2026 12:14:30 -0800 Subject: [PATCH] Some more TODOs --- .../execution_pending_envelope.rs | 2 ++ .../src/payload_envelope_verification/payload_notifier.rs | 1 + .../network/src/network_beacon_processor/gossip_methods.rs | 3 ++- 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/beacon_node/beacon_chain/src/payload_envelope_verification/execution_pending_envelope.rs b/beacon_node/beacon_chain/src/payload_envelope_verification/execution_pending_envelope.rs index dbd7478568..eea50d9fe1 100644 --- a/beacon_node/beacon_chain/src/payload_envelope_verification/execution_pending_envelope.rs +++ b/beacon_node/beacon_chain/src/payload_envelope_verification/execution_pending_envelope.rs @@ -44,6 +44,8 @@ impl IntoExecutionPendingEnvelope for GossipVerifiedEnve let envelope = &signed_envelope.message; let payload = &envelope.payload; + // TODO(gloas) + // Verify the execution payload is valid let payload_notifier = PayloadNotifier::new( chain.clone(), diff --git a/beacon_node/beacon_chain/src/payload_envelope_verification/payload_notifier.rs b/beacon_node/beacon_chain/src/payload_envelope_verification/payload_notifier.rs index a468bc5bc4..592d46022a 100644 --- a/beacon_node/beacon_chain/src/payload_envelope_verification/payload_notifier.rs +++ b/beacon_node/beacon_chain/src/payload_envelope_verification/payload_notifier.rs @@ -29,6 +29,7 @@ impl PayloadNotifier { let payload_verification_status = { let payload_message = &envelope.message; + // TODO(gloas) re-asses if optimistic syncing works similarly post-gloas match notify_execution_layer { NotifyExecutionLayer::No if chain.config.optimistic_finalized_sync => { let new_payload_request = Self::build_new_payload_request(&envelope, &block)?; diff --git a/beacon_node/network/src/network_beacon_processor/gossip_methods.rs b/beacon_node/network/src/network_beacon_processor/gossip_methods.rs index 89563c2ec3..f8636f5429 100644 --- a/beacon_node/network/src/network_beacon_processor/gossip_methods.rs +++ b/beacon_node/network/src/network_beacon_processor/gossip_methods.rs @@ -3272,7 +3272,8 @@ impl NetworkBeaconProcessor { Span::current().record("beacon_block_root", beacon_block_root.to_string()); // TODO(gloas) in process_gossip_block here we check_and_insert on the duplicate cache - // before calling gossip_verified_block + // before calling gossip_verified_block. We need this to ensure we dont try to execute the + // payload multiple times. self.process_gossip_verified_execution_payload_envelope( peer_id,