gnosis/lighthouse
1
0
Fork 0
mirror of https://github.com/sigp/lighthouse.git synced 2026-05-07 16:55:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add is_optimistic_candidate_block to fork choice

Browse Source
This commit is contained in:
Paul Hauner
2022-02-26 11:16:55 +11:00
parent 418f836f63
commit 8c304613fd
2 changed files with 38 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
consensus/fork_choice/src/fork_choice.rs
View File

@@ -910,7 +910,14 @@ where
.is_descendant(self.fc_store.finalized_checkpoint().root, block_root)
}
pub fn safe_to_import_optimistically(
/// Returns `Ok(false)` if a block is not viable to be imported optimistically.
///
/// ## Notes
///
/// Equivalent to the function with the same name in the optimistic sync specs:
///
/// https://github.com/ethereum/consensus-specs/blob/dev/sync/optimistic.md#helpers
pub fn is_optimistic_candidate_block(
&self,
current_slot: Slot,
block_slot: Slot,
@@ -918,13 +925,24 @@ where
spec: &ChainSpec,
) -> Result<bool, Error<T::Error>> {
// If the block is sufficiently old, import it.
if block_slot + spec.safe_slots_to_import_optimistically > current_slot {
if block_slot + spec.safe_slots_to_import_optimistically <= current_slot {
return Ok(true);
}
// If the justified block has execution enabled, then optimistically import any block.
if self
.get_justified_block()?
.execution_status
.is_execution_enabled()
{
return Ok(true);
}
// If the block has an ancestor with a verified parent, import this block.
//
// TODO(paul): this is not in the spec, add it.
// TODO: This condition is not yet merged into the spec. See:
//
// https://github.com/ethereum/consensus-specs/pull/2841
//
// ## Note
//
@@ -937,15 +955,6 @@ where
return Ok(true);
}
// If the justified block has execution enabled, then optimistically import any block.
if !self
.get_justified_block()?
.execution_status
.is_execution_enabled()
{
return Ok(true);
}
Ok(false)
}