gnosis/lighthouse
1
0
Fork 0
mirror of https://github.com/sigp/lighthouse.git synced 2026-05-30 12:47:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix pending_payload_cache tests for sampling column filtering

Browse Source 
Tests were switched from put_kzg_verified_custody_data_columns (no
filtering) to put_rpc_custody_columns (filters to sampling columns) but
assertions still assumed all provided columns would be stored. Account
for the sampling filter in each test's setup and assertions.
This commit is contained in:
Daniel Knopik
2026-04-30 14:52:45 +02:00
parent 4b1aab9fb7
commit 8e199552d6
1 changed files with 30 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
beacon_node/beacon_chain/src/pending_payload_cache/mod.rs
View File

@@ -756,7 +756,15 @@ mod data_availability_checker_tests {
let (harness, cache, _path) = setup().await;
let (bid, block_root, data_columns) =
init_block(&cache, &harness.spec, NumBlobs::Number(1), RNG_SEED);
let column = data_columns.first().cloned().expect("should have column");
let epoch = bid.slot.epoch(E::slots_per_epoch());
let sampling_cols = cache
.custody_context()
.sampling_columns_for_epoch(epoch, &harness.spec);
let column = data_columns
.iter()
.find(|c| sampling_cols.contains(c.index()))
.cloned()
.expect("should have a sampling column");
let column_index = *column.index();
for _ in 0..2 {
@@ -782,6 +790,12 @@ mod data_availability_checker_tests {
let (bid, block_root, data_columns) =
init_block(&cache, &harness.spec, NumBlobs::Number(1), RNG_SEED);
let epoch = bid.slot.epoch(E::slots_per_epoch());
let num_sampling_columns = cache
.custody_context()
.sampling_columns_for_epoch(epoch, &harness.spec)
.len();
let result = cache
.put_rpc_custody_columns(block_root, bid.clone(), data_columns)
.expect("should put columns");
@@ -794,7 +808,7 @@ mod data_availability_checker_tests {
panic!("expected available envelope");
};
assert_eq!(envelope.block_root, block_root);
assert_eq!(envelope.envelope.columns.len(), E::number_of_columns());
assert_eq!(envelope.envelope.columns.len(), num_sampling_columns);
}
#[tokio::test]
@@ -834,7 +848,17 @@ mod data_availability_checker_tests {
let (harness, cache, _path) = setup().await;
let (bid, block_root, data_columns) =
init_block(&cache, &harness.spec, NumBlobs::Number(1), RNG_SEED);
let columns = data_columns.into_iter().take(5).collect();
let epoch = bid.slot.epoch(E::slots_per_epoch());
let sampling_cols = cache
.custody_context()
.sampling_columns_for_epoch(epoch, &harness.spec);
let columns: Vec<_> = data_columns
.into_iter()
.filter(|c| sampling_cols.contains(c.index()))
.take(5)
.collect();
let num_columns = columns.len();
cache
.put_rpc_custody_columns(block_root, bid, columns)
@@ -843,7 +867,7 @@ mod data_availability_checker_tests {
cache
.cached_data_column_indexes(&block_root)
.map(|indices| indices.len()),
Some(5)
Some(num_columns)
);
cache.handle_reconstruction_failure(&block_root);
@@ -875,6 +899,7 @@ mod data_availability_checker_tests {
let (harness, cache, _path) = setup().await;
let (bid, block_root, data_columns) =
init_block(&cache, &harness.spec, NumBlobs::Number(1), RNG_SEED);
let block_epoch = bid.slot.epoch(E::slots_per_epoch());
let column = data_columns.first().cloned().expect("should have column");
cache
@@ -883,7 +908,7 @@ mod data_availability_checker_tests {
assert_eq!(cache.block_cache_size(), 1);
cache
.do_maintenance(Epoch::new(1))
.do_maintenance(block_epoch + 1)
.expect("maintenance should succeed");
assert_eq!(cache.block_cache_size(), 0);
}