make tests work for all forks

.github/workflows/test-suite.yml

@@ -118,6 +118,20 @@ jobs:
         repo-token: ${{ secrets.GITHUB_TOKEN }}
     - name: Run operation_pool tests for all known forks
       run: make test-op-pool
+  network-minimal-tests:
+    name: network-minimal-tests
+    runs-on: ubuntu-latest
+    needs: cargo-fmt
+    steps:
+    - uses: actions/checkout@v3
+    - name: Get latest version of stable Rust
+      run: rustup update stable
+    - name: Install Protoc
+      uses: arduino/setup-protoc@e52d9eb8f7b63115df1ac544a1376fdbf5a39612
+      with:
+        repo-token: ${{ secrets.GITHUB_TOKEN }}
+    - name: Run network tests for all known forks using the minimal spec
+      run: make test-network-minimal
   slasher-tests:
     name: slasher-tests
     runs-on: ubuntu-latest

Makefile

@@ -143,6 +143,13 @@ test-op-pool-%:
 		--features 'beacon_chain/fork_from_env'\
 		-p operation_pool
 
+test-network-minimal: $(patsubst %,test-network-minimal-%,$(FORKS))
+
+test-network-minimal-%:
+	env FORK_NAME=$* cargo test --release \
+		--features 'fork_from_env,spec-minimal'\
+		-p network
+
 # Run the tests in the `slasher` crate for all supported database backends.
 test-slasher:
 	cargo test --release -p slasher --features mdbx

beacon_node/beacon_chain/src/test_utils.rs

@@ -61,7 +61,7 @@ use types::{typenum::U4294967296, *};
 // 4th September 2019
 pub const HARNESS_GENESIS_TIME: u64 = 1_567_552_690;
 // Environment variable to read if `fork_from_env` feature is enabled.
-const FORK_NAME_ENV_VAR: &str = "FORK_NAME";
+pub const FORK_NAME_ENV_VAR: &str = "FORK_NAME";
 
 // Default target aggregators to set during testing, this ensures an aggregator at each slot.
 //

beacon_node/network/src/subnet_service/attestation_subnets.rs

@@ -3,7 +3,10 @@
 //! determines whether attestations should be aggregated and/or passed to the beacon node.
 
 use super::SubnetServiceMessage;
-#[cfg(any(test, feature = "deterministic_long_lived_attnets"))]
+#[cfg(any(
+    all(test, feature = "spec-mainnet"),
+    feature = "deterministic_long_lived_attnets"
+))]
 use std::collections::HashSet;
 use std::collections::{HashMap, VecDeque};
 use std::pin::Pin;
@@ -201,7 +204,7 @@ impl<T: BeaconChainTypes> AttestationService<T> {
     }
 
     /// Return count of all currently subscribed subnets (long-lived **and** short-lived).
-    #[cfg(test)]
+    #[cfg(all(test, feature = "spec-mainnet"))]
     pub fn subscription_count(&self) -> usize {
         if self.subscribe_all_subnets {
             self.beacon_chain.spec.attestation_subnet_count as usize
@@ -225,7 +228,7 @@ impl<T: BeaconChainTypes> AttestationService<T> {
     }
 
     /// Returns whether we are subscribed to a subnet for testing purposes.
-    #[cfg(test)]
+    #[cfg(all(test, feature = "spec-mainnet"))]
     pub(crate) fn is_subscribed(
         &self,
         subnet_id: &SubnetId,

beacon_node/network/src/subnet_service/sync_subnets.rs

@@ -87,7 +87,7 @@ impl<T: BeaconChainTypes> SyncCommitteeService<T> {
     }
 
     /// Return count of all currently subscribed subnets.
-    #[cfg(test)]
+    #[cfg(all(test, feature = "spec-mainnet"))]
     pub fn subscription_count(&self) -> usize {
         use types::consts::altair::SYNC_COMMITTEE_SUBNET_COUNT;
         if self.subscribe_all_subnets {

beacon_node/network/src/subnet_service/tests/mod.rs

@@ -1,3 +1,4 @@
+#![cfg(feature = "spec-mainnet")]
 use super::*;
 use beacon_chain::{
     builder::{BeaconChainBuilder, Witness},

beacon_node/network/src/sync/block_lookups/tests.rs

@@ -1,3 +1,4 @@
+#![cfg(feature = "spec-minimal")]
 use std::sync::Arc;
 
 use crate::service::RequestId;
@@ -36,6 +37,11 @@ struct TestRig {
 
 const D: Duration = Duration::new(0, 0);
 
+enum NumBlobs {
+    Random,
+    None,
+}
+
 impl TestRig {
     fn test_setup(enable_log: bool) -> (BlockLookups<T>, SyncNetworkContext<T>, Self) {
         let log = build_log(slog::Level::Debug, enable_log);
@@ -79,12 +85,13 @@ impl TestRig {
     }
 
     fn rand_block(&mut self, fork_name: ForkName) -> SignedBeaconBlock<E> {
-        self.rand_block_and_blobs(fork_name).0
+        self.rand_block_and_blobs(fork_name, NumBlobs::None).0
     }
 
     fn rand_block_and_blobs(
         &mut self,
         fork_name: ForkName,
+        num_blobs: NumBlobs,
     ) -> (SignedBeaconBlock<E>, Vec<BlobSidecar<E>>) {
         let inner = map_fork_name!(fork_name, BeaconBlock, <_>::random_for_test(&mut self.rng));
         let mut block =
@@ -93,7 +100,10 @@ impl TestRig {
         if let Ok(message) = block.message_deneb_mut() {
             // get random number between 0 and Max Blobs
             let mut payload: &mut FullPayloadDeneb<E> = &mut message.body.execution_payload;
-            let num_blobs = rand::random::<usize>() % E::max_blobs_per_block();
+            let num_blobs = match num_blobs {
+                NumBlobs::Random => rand::random::<usize>() % E::max_blobs_per_block(),
+                NumBlobs::None => 0,
+            };
             let (bundle, transactions) = execution_layer::test_utils::generate_random_blobs::<E>(
                 num_blobs,
                 &self.harness.chain.kzg.as_ref().unwrap(),
@@ -239,16 +249,14 @@ impl TestRig {
     }
 }
 
-macro_rules! common_tests {
-    ($mod_name: ident, $fork_name: ident) => {
-        #[cfg(test)]
-        mod $mod_name {
-            use super::*;
 #[test]
 fn test_single_block_lookup_happy_path() {
-                let fork_name = ForkName::$fork_name;
     let response_type = ResponseType::Block;
     let (mut bl, mut cx, mut rig) = TestRig::test_setup(false);
+    let fork_name = rig
+        .harness
+        .spec
+        .fork_name_at_slot::<E>(rig.harness.chain.slot().unwrap());
 
     let block = rig.rand_block(fork_name);
     let peer_id = PeerId::random();
@@ -256,6 +264,11 @@ macro_rules! common_tests {
     // Trigger the request
     bl.search_block(block_root, peer_id, PeerShouldHave::BlockAndBlobs, &mut cx);
     let id = rig.expect_block_request(response_type);
+    // If we're in deneb, a blob request should have been triggered as well,
+    // we don't require a response because we're generateing 0-blob blocks in this test.
+    if matches!(fork_name, ForkName::Deneb) {
+        let _ = rig.expect_block_request(ResponseType::Blob);
+    }
 
     // The peer provides the correct block, should not be penalized. Now the block should be sent
     // for processing.
@@ -283,6 +296,10 @@ macro_rules! common_tests {
 fn test_single_block_lookup_empty_response() {
     let response_type = ResponseType::Block;
     let (mut bl, mut cx, mut rig) = TestRig::test_setup(false);
+    let fork_name = rig
+        .harness
+        .spec
+        .fork_name_at_slot::<E>(rig.harness.chain.slot().unwrap());
 
     let block_hash = Hash256::random();
     let peer_id = PeerId::random();
@@ -290,6 +307,11 @@ macro_rules! common_tests {
     // Trigger the request
     bl.search_block(block_hash, peer_id, PeerShouldHave::BlockAndBlobs, &mut cx);
     let id = rig.expect_block_request(response_type);
+    // If we're in deneb, a blob request should have been triggered as well,
+    // we don't require a response because we're generateing 0-blob blocks in this test.
+    if matches!(fork_name, ForkName::Deneb) {
+        let _ = rig.expect_block_request(ResponseType::Blob);
+    }
 
     // The peer does not have the block. It should be penalized.
     bl.single_block_lookup_response(id, peer_id, None, D, &mut cx);
@@ -300,16 +322,24 @@ macro_rules! common_tests {
 
 #[test]
 fn test_single_block_lookup_wrong_response() {
-                let fork_name = ForkName::$fork_name;
     let response_type = ResponseType::Block;
     let (mut bl, mut cx, mut rig) = TestRig::test_setup(false);
 
+    let fork_name = rig
+        .harness
+        .spec
+        .fork_name_at_slot::<E>(rig.harness.chain.slot().unwrap());
     let block_hash = Hash256::random();
     let peer_id = PeerId::random();
 
     // Trigger the request
     bl.search_block(block_hash, peer_id, PeerShouldHave::BlockAndBlobs, &mut cx);
     let id = rig.expect_block_request(response_type);
+    // If we're in deneb, a blob request should have been triggered as well,
+    // we don't require a response because we're generateing 0-blob blocks in this test.
+    if matches!(fork_name, ForkName::Deneb) {
+        let _ = rig.expect_block_request(ResponseType::Blob);
+    }
 
     // Peer sends something else. It should be penalized.
     let bad_block = rig.rand_block(fork_name);
@@ -327,12 +357,21 @@ macro_rules! common_tests {
     let response_type = ResponseType::Block;
     let (mut bl, mut cx, mut rig) = TestRig::test_setup(false);
 
+    let fork_name = rig
+        .harness
+        .spec
+        .fork_name_at_slot::<E>(rig.harness.chain.slot().unwrap());
     let block_hash = Hash256::random();
     let peer_id = PeerId::random();
 
     // Trigger the request
     bl.search_block(block_hash, peer_id, PeerShouldHave::BlockAndBlobs, &mut cx);
     let id = rig.expect_block_request(response_type);
+    // If we're in deneb, a blob request should have been triggered as well,
+    // we don't require a response because we're generateing 0-blob blocks in this test.
+    if matches!(fork_name, ForkName::Deneb) {
+        let _ = rig.expect_block_request(ResponseType::Blob);
+    }
 
     // The request fails. RPC failures are handled elsewhere so we should not penalize the peer.
     bl.single_block_lookup_failed(id, &peer_id, &mut cx, RPCError::UnsupportedProtocol);
@@ -342,10 +381,13 @@ macro_rules! common_tests {
 
 #[test]
 fn test_single_block_lookup_becomes_parent_request() {
-                let fork_name = ForkName::$fork_name;
     let response_type = ResponseType::Block;
     let (mut bl, mut cx, mut rig) = TestRig::test_setup(false);
 
+    let fork_name = rig
+        .harness
+        .spec
+        .fork_name_at_slot::<E>(rig.harness.chain.slot().unwrap());
     let block = Arc::new(rig.rand_block(fork_name));
     let peer_id = PeerId::random();
 
@@ -357,6 +399,11 @@ macro_rules! common_tests {
         &mut cx,
     );
     let id = rig.expect_block_request(response_type);
+    // If we're in deneb, a blob request should have been triggered as well,
+    // we don't require a response because we're generateing 0-blob blocks in this test.
+    if matches!(fork_name, ForkName::Deneb) {
+        let _ = rig.expect_block_request(ResponseType::Blob);
+    }
 
     // The peer provides the correct block, should not be penalized. Now the block should be sent
     // for processing.
@@ -377,16 +424,24 @@ macro_rules! common_tests {
     );
     assert_eq!(bl.single_block_lookups.len(), 1);
     rig.expect_parent_request(response_type);
+    // If we're in deneb, a blob request should have been triggered as well,
+    // we don't require a response because we're generateing 0-blob blocks in this test.
+    if matches!(fork_name, ForkName::Deneb) {
+        let _ = rig.expect_parent_request(ResponseType::Blob);
+    }
     rig.expect_empty_network();
     assert_eq!(bl.parent_lookups.len(), 1);
 }
 
 #[test]
 fn test_parent_lookup_happy_path() {
-                let fork_name = ForkName::$fork_name;
     let response_type = ResponseType::Block;
     let (mut bl, mut cx, mut rig) = TestRig::test_setup(false);
 
+    let fork_name = rig
+        .harness
+        .spec
+        .fork_name_at_slot::<E>(rig.harness.chain.slot().unwrap());
     let parent = rig.rand_block(fork_name);
     let block = rig.block_with_parent(parent.canonical_root(), fork_name);
     let chain_hash = block.canonical_root();
@@ -398,6 +453,11 @@ macro_rules! common_tests {
     // Trigger the request
     bl.search_parent(slot, block_root, parent_root, peer_id, &mut cx);
     let id = rig.expect_parent_request(response_type);
+    // If we're in deneb, a blob request should have been triggered as well,
+    // we don't require a response because we're generateing 0-blob blocks in this test.
+    if matches!(fork_name, ForkName::Deneb) {
+        let _ = rig.expect_parent_request(ResponseType::Blob);
+    }
 
     // Peer sends the right block, it should be sent for processing. Peer should not be penalized.
     bl.parent_lookup_response(id, peer_id, Some(parent.into()), D, &mut cx);
@@ -421,10 +481,13 @@ macro_rules! common_tests {
 
 #[test]
 fn test_parent_lookup_wrong_response() {
-                let fork_name = ForkName::$fork_name;
     let response_type = ResponseType::Block;
     let (mut bl, mut cx, mut rig) = TestRig::test_setup(false);
 
+    let fork_name = rig
+        .harness
+        .spec
+        .fork_name_at_slot::<E>(rig.harness.chain.slot().unwrap());
     let parent = rig.rand_block(fork_name);
     let block = rig.block_with_parent(parent.canonical_root(), fork_name);
     let chain_hash = block.canonical_root();
@@ -436,6 +499,11 @@ macro_rules! common_tests {
     // Trigger the request
     bl.search_parent(slot, block_root, parent_root, peer_id, &mut cx);
     let id1 = rig.expect_parent_request(response_type);
+    // If we're in deneb, a blob request should have been triggered as well,
+    // we don't require a response because we're generateing 0-blob blocks in this test.
+    if matches!(fork_name, ForkName::Deneb) {
+        let _ = rig.expect_parent_request(ResponseType::Blob);
+    }
 
     // Peer sends the wrong block, peer should be penalized and the block re-requested.
     let bad_block = rig.rand_block(fork_name);
@@ -468,10 +536,13 @@ macro_rules! common_tests {
 
 #[test]
 fn test_parent_lookup_empty_response() {
-                let fork_name = ForkName::$fork_name;
     let response_type = ResponseType::Block;
     let (mut bl, mut cx, mut rig) = TestRig::test_setup(false);
 
+    let fork_name = rig
+        .harness
+        .spec
+        .fork_name_at_slot::<E>(rig.harness.chain.slot().unwrap());
     let parent = rig.rand_block(fork_name);
     let block = rig.block_with_parent(parent.canonical_root(), fork_name);
     let chain_hash = block.canonical_root();
@@ -483,6 +554,11 @@ macro_rules! common_tests {
     // Trigger the request
     bl.search_parent(slot, block_root, parent_root, peer_id, &mut cx);
     let id1 = rig.expect_parent_request(response_type);
+    // If we're in deneb, a blob request should have been triggered as well,
+    // we don't require a response because we're generateing 0-blob blocks in this test.
+    if matches!(fork_name, ForkName::Deneb) {
+        let _ = rig.expect_parent_request(ResponseType::Blob);
+    }
 
     // Peer sends an empty response, peer should be penalized and the block re-requested.
     bl.parent_lookup_response(id1, peer_id, None, D, &mut cx);
@@ -510,10 +586,13 @@ macro_rules! common_tests {
 
 #[test]
 fn test_parent_lookup_rpc_failure() {
-                let fork_name = ForkName::$fork_name;
     let response_type = ResponseType::Block;
     let (mut bl, mut cx, mut rig) = TestRig::test_setup(false);
 
+    let fork_name = rig
+        .harness
+        .spec
+        .fork_name_at_slot::<E>(rig.harness.chain.slot().unwrap());
     let parent = rig.rand_block(fork_name);
     let block = rig.block_with_parent(parent.canonical_root(), fork_name);
     let chain_hash = block.canonical_root();
@@ -525,6 +604,11 @@ macro_rules! common_tests {
     // Trigger the request
     bl.search_parent(slot, block_root, parent_root, peer_id, &mut cx);
     let id1 = rig.expect_parent_request(response_type);
+    // If we're in deneb, a blob request should have been triggered as well,
+    // we don't require a response because we're generateing 0-blob blocks in this test.
+    if matches!(fork_name, ForkName::Deneb) {
+        let _ = rig.expect_parent_request(ResponseType::Blob);
+    }
 
     // The request fails. It should be tried again.
     bl.parent_lookup_failed(
@@ -559,10 +643,13 @@ macro_rules! common_tests {
 
 #[test]
 fn test_parent_lookup_too_many_attempts() {
-                let fork_name = ForkName::$fork_name;
     let response_type = ResponseType::Block;
     let (mut bl, mut cx, mut rig) = TestRig::test_setup(false);
 
+    let fork_name = rig
+        .harness
+        .spec
+        .fork_name_at_slot::<E>(rig.harness.chain.slot().unwrap());
     let parent = rig.rand_block(fork_name);
     let block = rig.block_with_parent(parent.canonical_root(), fork_name);
     let peer_id = PeerId::random();
@@ -574,6 +661,11 @@ macro_rules! common_tests {
     bl.search_parent(slot, block_root, parent_root, peer_id, &mut cx);
     for i in 1..=parent_lookup::PARENT_FAIL_TOLERANCE {
         let id = rig.expect_parent_request(response_type);
+        // If we're in deneb, a blob request should have been triggered as well,
+        // we don't require a response because we're generateing 0-blob blocks in this test.
+        if matches!(fork_name, ForkName::Deneb) && i == 1 {
+            let _ = rig.expect_parent_request(ResponseType::Blob);
+        }
         match i % 2 {
             // make sure every error is accounted for
             0 => {
@@ -591,13 +683,7 @@ macro_rules! common_tests {
             _ => {
                 // Send a bad block this time. It should be tried again.
                 let bad_block = rig.rand_block(fork_name);
-                            bl.parent_lookup_response(
+                bl.parent_lookup_response(id, peer_id, Some(bad_block.into()), D, &mut cx);
-                                id,
-                                peer_id,
-                                Some(bad_block.into()),
-                                D,
-                                &mut cx,
-                            );
                 // Send the stream termination
                 bl.parent_lookup_response(id, peer_id, None, D, &mut cx);
                 rig.expect_penalty();
@@ -613,10 +699,13 @@ macro_rules! common_tests {
 
 #[test]
 fn test_parent_lookup_too_many_download_attempts_no_blacklist() {
-                let fork_name = ForkName::$fork_name;
     let response_type = ResponseType::Block;
     let (mut bl, mut cx, mut rig) = TestRig::test_setup(false);
 
+    let fork_name = rig
+        .harness
+        .spec
+        .fork_name_at_slot::<E>(rig.harness.chain.slot().unwrap());
     let parent = rig.rand_block(fork_name);
     let block = rig.block_with_parent(parent.canonical_root(), fork_name);
     let block_hash = block.canonical_root();
@@ -630,6 +719,11 @@ macro_rules! common_tests {
     for i in 1..=parent_lookup::PARENT_FAIL_TOLERANCE {
         assert!(!bl.failed_chains.contains(&block_hash));
         let id = rig.expect_parent_request(response_type);
+        // If we're in deneb, a blob request should have been triggered as well,
+        // we don't require a response because we're generateing 0-blob blocks in this test.
+        if matches!(fork_name, ForkName::Deneb) && i == 1 {
+            let _ = rig.expect_parent_request(ResponseType::Blob);
+        }
         if i % 2 != 0 {
             // The request fails. It should be tried again.
             bl.parent_lookup_failed(
@@ -659,10 +753,13 @@ macro_rules! common_tests {
 
 #[test]
 fn test_parent_lookup_too_many_processing_attempts_must_blacklist() {
-                let fork_name = ForkName::$fork_name;
     let response_type = ResponseType::Block;
     const PROCESSING_FAILURES: u8 = parent_lookup::PARENT_FAIL_TOLERANCE / 2 + 1;
     let (mut bl, mut cx, mut rig) = TestRig::test_setup(false);
+    let fork_name = rig
+        .harness
+        .spec
+        .fork_name_at_slot::<E>(rig.harness.chain.slot().unwrap());
 
     let parent = Arc::new(rig.rand_block(fork_name));
     let block = rig.block_with_parent(parent.canonical_root(), fork_name);
@@ -675,8 +772,13 @@ macro_rules! common_tests {
     bl.search_parent(slot, block_root, parent_root, peer_id, &mut cx);
 
     // Fail downloading the block
-                for _ in 0..(parent_lookup::PARENT_FAIL_TOLERANCE - PROCESSING_FAILURES) {
+    for i in 0..(parent_lookup::PARENT_FAIL_TOLERANCE - PROCESSING_FAILURES) {
         let id = rig.expect_parent_request(response_type);
+        // If we're in deneb, a blob request should have been triggered as well,
+        // we don't require a response because we're generateing 0-blob blocks in this test.
+        if matches!(fork_name, ForkName::Deneb) && i == 0 {
+            let _ = rig.expect_parent_request(ResponseType::Blob);
+        }
         // The request fails. It should be tried again.
         bl.parent_lookup_failed(
             id,
@@ -692,6 +794,8 @@ macro_rules! common_tests {
     // Now fail processing a block in the parent request
     for _ in 0..PROCESSING_FAILURES {
         let id = dbg!(rig.expect_parent_request(response_type));
+        // If we're in deneb, a blob request should have been triggered as well,
+        // we don't require a response because we're generateing 0-blob blocks in this test.
         assert!(!bl.failed_chains.contains(&block_root));
         // send the right parent but fail processing
         bl.parent_lookup_response(id, peer_id, Some(parent.clone()), D, &mut cx);
@@ -711,12 +815,14 @@ macro_rules! common_tests {
 
 #[test]
 fn test_parent_lookup_too_deep() {
-                let fork_name = ForkName::$fork_name;
     let response_type = ResponseType::Block;
     let (mut bl, mut cx, mut rig) = TestRig::test_setup(false);
-                let mut blocks = Vec::<Arc<SignedBeaconBlock<E>>>::with_capacity(
+    let fork_name = rig
-                    parent_lookup::PARENT_DEPTH_TOLERANCE,
+        .harness
-                );
+        .spec
+        .fork_name_at_slot::<E>(rig.harness.chain.slot().unwrap());
+    let mut blocks =
+        Vec::<Arc<SignedBeaconBlock<E>>>::with_capacity(parent_lookup::PARENT_DEPTH_TOLERANCE);
     while blocks.len() < parent_lookup::PARENT_DEPTH_TOLERANCE {
         let parent = blocks
             .last()
@@ -742,6 +848,12 @@ macro_rules! common_tests {
 
     for block in blocks.into_iter().rev() {
         let id = rig.expect_parent_request(response_type);
+        // If we're in deneb, a blob request should have been triggered as well,
+        // we don't require a response because we're generateing 0-blob blocks in this test.
+        if matches!(fork_name, ForkName::Deneb) {
+            dbg!("here");
+            let _ = rig.expect_parent_request(ResponseType::Blob);
+        }
         // the block
         bl.parent_lookup_response(id, peer_id, Some(block.clone()), D, &mut cx);
         // the stream termination
@@ -763,9 +875,12 @@ macro_rules! common_tests {
 
 #[test]
 fn test_parent_lookup_disconnection() {
-                let fork_name = ForkName::$fork_name;
     let (mut bl, mut cx, mut rig) = TestRig::test_setup(false);
     let peer_id = PeerId::random();
+    let fork_name = rig
+        .harness
+        .spec
+        .fork_name_at_slot::<E>(rig.harness.chain.slot().unwrap());
     let trigger_block = rig.rand_block(fork_name);
     let trigger_block_root = trigger_block.canonical_root();
     let trigger_parent_root = trigger_block.parent_root();
@@ -784,10 +899,13 @@ macro_rules! common_tests {
 
 #[test]
 fn test_single_block_lookup_ignored_response() {
-                let fork_name = ForkName::$fork_name;
     let response_type = ResponseType::Block;
     let (mut bl, mut cx, mut rig) = TestRig::test_setup(false);
 
+    let fork_name = rig
+        .harness
+        .spec
+        .fork_name_at_slot::<E>(rig.harness.chain.slot().unwrap());
     let block = rig.rand_block(fork_name);
     let peer_id = PeerId::random();
 
@@ -799,6 +917,11 @@ macro_rules! common_tests {
         &mut cx,
     );
     let id = rig.expect_block_request(response_type);
+    // If we're in deneb, a blob request should have been triggered as well,
+    // we don't require a response because we're generateing 0-blob blocks in this test.
+    if matches!(fork_name, ForkName::Deneb) {
+        let _ = rig.expect_block_request(ResponseType::Blob);
+    }
 
     // The peer provides the correct block, should not be penalized. Now the block should be sent
     // for processing.
@@ -813,22 +936,20 @@ macro_rules! common_tests {
     // after processing.
     bl.single_block_lookup_response(id, peer_id, None, D, &mut cx);
     // Send an Ignored response, the request should be dropped
-                bl.single_block_processed(
+    bl.single_block_processed(id, BlockProcessingResult::Ignored, response_type, &mut cx);
-                    id,
-                    BlockProcessingResult::Ignored,
-                    response_type,
-                    &mut cx,
-                );
     rig.expect_empty_network();
     assert_eq!(bl.single_block_lookups.len(), 0);
 }
 
 #[test]
 fn test_parent_lookup_ignored_response() {
-                let fork_name = ForkName::$fork_name;
     let response_type = ResponseType::Block;
     let (mut bl, mut cx, mut rig) = TestRig::test_setup(false);
 
+    let fork_name = rig
+        .harness
+        .spec
+        .fork_name_at_slot::<E>(rig.harness.chain.slot().unwrap());
     let parent = rig.rand_block(fork_name);
     let block = rig.block_with_parent(parent.canonical_root(), fork_name);
     let chain_hash = block.canonical_root();
@@ -841,6 +962,12 @@ macro_rules! common_tests {
     bl.search_parent(slot, block_root, parent_root, peer_id, &mut cx);
     let id = rig.expect_parent_request(response_type);
 
+    // If we're in deneb, a blob request should have been triggered as well,
+    // we don't require a response because we're generateing 0-blob blocks in this test.
+    if matches!(fork_name, ForkName::Deneb) {
+        let _ = rig.expect_parent_request(ResponseType::Blob);
+    }
+
     // Peer sends the right block, it should be sent for processing. Peer should not be penalized.
     bl.parent_lookup_response(id, peer_id, Some(parent.into()), D, &mut cx);
     rig.expect_block_process(response_type);
@@ -860,10 +987,13 @@ macro_rules! common_tests {
 /// This is a regression test.
 #[test]
 fn test_same_chain_race_condition() {
-                let fork_name = ForkName::$fork_name;
     let response_type = ResponseType::Block;
     let (mut bl, mut cx, mut rig) = TestRig::test_setup(true);
 
+    let fork_name = rig
+        .harness
+        .spec
+        .fork_name_at_slot::<E>(rig.harness.chain.slot().unwrap());
     #[track_caller]
     fn parent_lookups_consistency(bl: &BlockLookups<T>) {
         let hashes: Vec<_> = bl
@@ -910,6 +1040,11 @@ macro_rules! common_tests {
 
     for (i, block) in blocks.into_iter().rev().enumerate() {
         let id = rig.expect_parent_request(response_type);
+        // If we're in deneb, a blob request should have been triggered as well,
+        // we don't require a response because we're generateing 0-blob blocks in this test.
+        if matches!(fork_name, ForkName::Deneb) {
+            let _ = rig.expect_parent_request(ResponseType::Blob);
+        }
         // the block
         bl.parent_lookup_response(id, peer_id, Some(block.clone()), D, &mut cx);
         // the stream termination
@@ -959,27 +1094,37 @@ macro_rules! common_tests {
     bl.parent_chain_processed(chain_hash, process_result, &mut cx);
     assert_eq!(bl.parent_lookups.len(), 0);
 }
-        }
-    };
-}
-
-common_tests!(base, Base);
-common_tests!(capella, Capella);
-common_tests!(deneb, Deneb);
 
 mod deneb_only {
     use super::*;
+    use std::str::FromStr;
+
+    fn get_fork_name() -> ForkName {
+        ForkName::from_str(
+            &std::env::var(beacon_chain::test_utils::FORK_NAME_ENV_VAR).unwrap_or_else(|e| {
+                panic!(
+                    "{} env var must be defined when using fork_from_env: {:?}",
+                    beacon_chain::test_utils::FORK_NAME_ENV_VAR,
+                    e
+                )
+            }),
+        )
+        .unwrap()
+    }
+
     #[test]
     fn test_single_block_lookup_happy_path() {
-        let fork_name = ForkName::Deneb;
+        let fork_name = get_fork_name();
-
+        if !matches!(fork_name, ForkName::Deneb) {
+            return;
+        }
         let (mut bl, mut cx, mut rig) = TestRig::test_setup(false);
         rig.harness
             .chain
             .slot_clock
             .set_slot(E::slots_per_epoch() * rig.harness.spec.deneb_fork_epoch.unwrap().as_u64());
 
-        let (block, blobs) = rig.rand_block_and_blobs(fork_name);
+        let (block, blobs) = rig.rand_block_and_blobs(fork_name, NumBlobs::Random);
         let slot = block.slot();
         let peer_id = PeerId::random();
         let block_root = block.canonical_root();