gnosis/lighthouse
1
0
Fork 0
mirror of https://github.com/sigp/lighthouse.git synced 2026-03-03 00:31:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Optimize attester slashing (#1745)

Browse Source 
## Issue Addressed

Closes #1548 

## Proposed Changes

Optimizes attester slashing choice by choosing the ones that cover the most amount of validators slashed, with the highest effective balances 

## Additional Info

Initial pass, need to write a test for it
This commit is contained in:
Daniel Schonfeld
2020-10-22 01:43:54 +00:00
parent 668513b67e
commit 8f86baa48d
4 changed files with 300 additions and 39 deletions
Download Patch File Download Diff File Expand all files Collapse all files

39
consensus/types/src/test_utils/builders/testing_attester_slashing_builder.rs
View File

@@ -21,6 +21,29 @@ impl TestingAttesterSlashingBuilder {
genesis_validators_root: Hash256,
spec: &ChainSpec,
) -> AttesterSlashing<T>
where
F: Fn(u64, &[u8]) -> Signature,
{
TestingAttesterSlashingBuilder::double_vote_with_additional_indices(
test_task,
validator_indices,
None,
signer,
fork,
genesis_validators_root,
spec,
)
}
pub fn double_vote_with_additional_indices<F, T: EthSpec>(
test_task: AttesterSlashingTestTask,
validator_indices: &[u64],
additional_validator_indices: Option<&[u64]>,
signer: F,
fork: &Fork,
genesis_validators_root: Hash256,
spec: &ChainSpec,
) -> AttesterSlashing<T>
where
F: Fn(u64, &[u8]) -> Signature,
{
@@ -73,13 +96,16 @@ impl TestingAttesterSlashingBuilder {
// Trigger bad validator indices ordering error.
vec![1, 0].into()
} else {
validator_indices.to_vec().into()
match additional_validator_indices {
Some(x) => x.to_vec().into(),
None => validator_indices.to_vec().into(),
}
},
data: data_2,
signature: AggregateSignature::empty(),
};
let add_signatures = |attestation: &mut IndexedAttestation<T>| {
let add_signatures = |attestation: &mut IndexedAttestation<T>, indices_to_sign: &[u64]| {
let domain = spec.get_domain(
attestation.data.target.epoch,
Domain::BeaconAttester,
@@ -88,14 +114,17 @@ impl TestingAttesterSlashingBuilder {
);
let message = attestation.data.signing_root(domain);
for validator_index in validator_indices {
for validator_index in indices_to_sign {
let signature = signer(*validator_index, message.as_bytes());
attestation.signature.add_assign(&signature);
}
};
add_signatures(&mut attestation_1);
add_signatures(&mut attestation_2);
add_signatures(&mut attestation_1, validator_indices);
add_signatures(
&mut attestation_2,
additional_validator_indices.unwrap_or(validator_indices),
);
AttesterSlashing {
attestation_1,