gnosis/lighthouse
1
0
Fork 0
mirror of https://github.com/sigp/lighthouse.git synced 2026-03-23 23:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix big in attestation validation

Browse Source 
There was no check that the attestation is within an appropriate
distance from its parent block.
This commit is contained in:
Paul Hauner
2018-10-13 09:39:10 +11:00
parent e8daca4c80
commit 90010ced55
2 changed files with 14 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
beacon_chain/validation/src/attestation_validation.rs
View File

@@ -29,6 +29,7 @@ use super::signature_verification::{
#[derive(Debug,PartialEq)]
pub enum AttestationValidationError {
ParentSlotTooHigh,
ParentSlotTooLow,
BlockSlotTooHigh,
BlockSlotTooLow,
JustifiedSlotIncorrect,
@@ -94,11 +95,11 @@ impl<T> AttestationValidationContext<T>
/*
* The slot of this attestation must not be more than cycle_length + 1 distance
* from the block that contained it.
* from the parent_slot of block that contained it.
*/
if a.slot < self.block_slot
if a.slot < self.parent_block_slot
.saturating_sub(u64::from(self.cycle_length).saturating_add(1)) {
return Err(AttestationValidationError::BlockSlotTooLow);
return Err(AttestationValidationError::ParentSlotTooLow);
}
/*