mirror of
https://github.com/sigp/lighthouse.git
synced 2026-03-17 03:42:46 +00:00
Sync peer attribution (#7733)
Which issue # does this PR address? Closes #7604 Improvements to range sync including: 1. Contain column requests only to peers that are part of the SyncingChain 2. Attribute the fault to the correct peer and downscore them if they don't return the data columns for the request 3. Improve sync performance by retrying only the failed columns from other peers instead of failing the entire batch 4. Uses the earliest_available_slot to make requests to peers that claim to have the epoch. Note: if no earliest_available_slot info is available, fallback to using previous logic i.e. assume peer has everything backfilled upto WS checkpoint/da boundary Tested this on fusaka-devnet-2 with a full node and supernode and the recovering logic seems to works well. Also tested this a little on mainnet. Need to do more testing and possibly add some unit tests.
This commit is contained in:
@@ -28,6 +28,19 @@ pub struct SyncInfo {
|
||||
pub earliest_available_slot: Option<Slot>,
|
||||
}
|
||||
|
||||
impl SyncInfo {
|
||||
/// Returns true if the provided slot is greater than or equal to the peer's `earliest_available_slot`.
|
||||
///
|
||||
/// If `earliest_available_slot` is None, then we just assume that the peer has the slot.
|
||||
pub fn has_slot(&self, slot: Slot) -> bool {
|
||||
if let Some(earliest_available_slot) = self.earliest_available_slot {
|
||||
slot >= earliest_available_slot
|
||||
} else {
|
||||
true
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
impl std::cmp::PartialEq for SyncStatus {
|
||||
fn eq(&self, other: &Self) -> bool {
|
||||
matches!(
|
||||
|
||||
Reference in New Issue
Block a user